From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9EAC433E0 for ; Fri, 15 Jan 2021 14:34:01 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EBA923772; Fri, 15 Jan 2021 14:34:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EBA923772 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1l0QAp-0002KM-O9; Fri, 15 Jan 2021 14:33:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0QAo-0002KE-KL for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Jan 2021 14:33:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JlKooYtElvoBMZ5GgPDQkCOzjeZLLHw0zI1ErnpiMME=; b=A6xDc67xfC3NN2x2PtRSSVURYQ AdvO+3V0Dxsp72AGyxMm5hAguVFLzzzcP+1wLIgbcNCMPuwNCD9P1gN4SGg7NmqlzMGRsgnlEt1PW Yoact7wMZYp+s7szG5M2bQuq0fIvQ67DcoNaRFQEjAmdDQ8JMXDBGQB3eGGDhZ4hbIe8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JlKooYtElvoBMZ5GgPDQkCOzjeZLLHw0zI1ErnpiMME=; b=DZ3MdlxO76uaBfQptHVHOrXTvc 8G3uVqVawmbB6uQG3yeE0RW8jO20lvRTxRmoMnGgzKlHxMsz1umsfwV0GxmhlNxbSNNOG+pKpebm4 8dIkRT341ggMt0hFgstG/ubFyF7hEA5V92C1poBNH7yrkipgPriII7rsA2/3w6hrk00c=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1l0QAb-004s0L-07 for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Jan 2021 14:33:58 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 06050224F9; Fri, 15 Jan 2021 14:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610721219; bh=JlKooYtElvoBMZ5GgPDQkCOzjeZLLHw0zI1ErnpiMME=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=n84OuihdpxPZSCEyu2+9PdEdvMGODoT7rfwGJKCJVQu+RWVvZv7kKTdyzVBwQHjER /KgPuCh4t/3RrSVuGEFnO+43KiugUEQ+1pxhLEnOjG+VoqPXRith5tGebZky3XctZ7 9vr+OIFeQnvqJPT313tBjeqbN2pO1vMzzFVrgPd7G5/h/7GEARTEleX6E83tTcZX4s f9LhQFOfAALetyeqoqT7wmf/2P/sel/bHB16EPXoStanCObOLhU3kP3C9tXWux6noH zaIb/UlThPWSsDD5ji8nY7q/9pFPFO5YQXKqPfPQyHG3SJ7Exv3FapLkH54c1lrrKy S1MzyvnqxCn9Q== To: Daeho Jeong , Chao Yu References: <20210114062302.3809664-1-daeho43@gmail.com> <965dc435-c0a0-36ca-7e97-c3aaa3831bff@huawei.com> From: Chao Yu Message-ID: Date: Fri, 15 Jan 2021 22:33:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Headers-End: 1l0QAb-004s0L-07 Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: introduce checkpoint=merge mount option X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sungjong Seo , kernel-team@android.com, Daeho Jeong , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/1/15 22:00, Daeho Jeong wrote: >> ktime_get() returns time based ns unit, in extreme scenario, average >> time cp cost will overflow 32-bit variable, I doubt. >> > sum_diff is already turned into msec using ktime_ms_delta() above. Yup, I missed ktime_ms_delta(). On 2021/1/15 22:23, Daeho Jeong wrote: >>> How about updating queued_ckpt and total_ckpt in batch, update atomic >>> variable one by one is low efficient. >>> >> You mean like using spin_lock()? >> > Ah, you mean like updating these values as much as the count of the > loop at once? Correct. :) Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel