From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 297C5C54EBD for ; Thu, 12 Jan 2023 10:15:01 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pFubs-0007Mb-KP; Thu, 12 Jan 2023 10:14:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFubX-0007MD-13 for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Jan 2023 10:14:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/c5Fx3TuaiNl3z9LI7DPQoGWqtNXp0hLanw0Zc4wWPQ=; b=iVOTBUqqFVCJpqobv9/YIa4kTd LIgd2OBVTnk3YIM5razKoy+dqUAQWYscamMOVKJRAzotsPy45HsdLeb5c8UO6jJtfrh757kQYSCoJ 1cfYOyzKXGjy4Te9HIiM9SdWE+mzfJOhquLkSg/UUElg7MCnLsekNIV9FkWH3B6iTUoo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/c5Fx3TuaiNl3z9LI7DPQoGWqtNXp0hLanw0Zc4wWPQ=; b=iaWMQapbHaPkeU/kfG/BV5kPey BRuj64R4F5Db5oFweVpHZn2EMowxbrRF+y4l/i9yjAVOy78xF1el2WCrs6rRuT5sBBz9tbn4QTwRU 7iRARj6dlPhZJEgJQeISGLZ26HOnzuxrCgQqbbJVQuhwe88uhL5GDbONeXRFxBryZJv0=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pFubU-000n8m-TJ for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Jan 2023 10:14:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 03DDFB81DF5 for ; Thu, 12 Jan 2023 10:14:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBBE5C433F1; Thu, 12 Jan 2023 10:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673518467; bh=H0qpAy+h+AneY0RPAYaiUWjuu9etUicEYCaT4nEEvoI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eZkRMqYwCXUCQxKOAi+15/baSqh41shr4qGIVTj4nISV5aSm9OiJcgOHHn+rrGn2+ EI+Ba1q+WT2FkAQpyn89m/hkyFDRC5R6g2Noxxb29XWasdBhYrTdAzdZidEPqDY1qK R03ofZub6YJtzTw4lPRWrjkylQ/g8tswTIEjq13KJR/73DFyF449aLNTcFnh6o5idY 0CaSVVKQup0CVXQZ5oq6mMEJbft88GLo3sq7ntzZyOJLkhEYuDeoFcTCMArg7sP/0g qWJ7DinLWOmu0Kei05Noo4Pt2DMRuDR2CiVgygBSBO+zJ1MKt7UhYcShhwe+aj+emM WDeeiiTHh8Tjg== Message-ID: Date: Thu, 12 Jan 2023 18:14:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Jaegeuk Kim References: <20230105233908.1030651-1-jaegeuk@kernel.org> <77b18266-69c4-c7f0-0eab-d2069a7b21d5@kernel.org> From: Chao Yu In-Reply-To: X-Headers-End: 1pFubU-000n8m-TJ Subject: Re: [f2fs-dev] [PATCH v2] f2fs: retry to update the inode page given EIO X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2023/1/12 2:50, Jaegeuk Kim wrote: > On 01/11, Chao Yu wrote: >> On 2023/1/11 9:20, Jaegeuk Kim wrote: >>> In f2fs_update_inode_page, f2fs_get_node_page handles EIO along with >>> f2fs_handle_page_eio that stops checkpoint, if the disk couldn't be recovered. >>> As a result, we don't need to stop checkpoint right away given single EIO. >> >> f2fs_handle_page_eio() only covers the case that EIO occurs on the same >> page, should we cover the case EIO occurs on different pages? > > Which case are you looking at? - __get_node_page(PageA) - __get_node_page(PageB) - f2fs_handle_page_eio - sbi->page_eio_ofs[type] = PageA->index - f2fs_handle_page_eio - sbi->page_eio_ofs[type] = PageB->index In such race case, it may has low probability to set CP_ERROR_FLAG as we expect? Thanks, > >> >> Thanks, >> >>> >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Randall Huang >>> Signed-off-by: Jaegeuk Kim >>> --- >>> >>> Change log from v1: >>> - fix a bug >>> >>> fs/f2fs/inode.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c >>> index ff6cf66ed46b..2ed7a621fdf1 100644 >>> --- a/fs/f2fs/inode.c >>> +++ b/fs/f2fs/inode.c >>> @@ -719,7 +719,7 @@ void f2fs_update_inode_page(struct inode *inode) >>> if (IS_ERR(node_page)) { >>> int err = PTR_ERR(node_page); >>> - if (err == -ENOMEM) { >>> + if (err == -ENOMEM || (err == -EIO && !f2fs_cp_error(sbi))) { >>> cond_resched(); >>> goto retry; >>> } else if (err != -ENOENT) { _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel