[f2fs-dev] [Bug 218770] New: fsck seems unable to solve corruption

[f2fs-dev] [Bug 218770] New: fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

            Bug ID: 218770
           Summary: fsck seems unable to solve corruption
           Product: File System
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: high
          Priority: P3
         Component: f2fs
          Assignee: filesystem_f2fs@kernel-bugs.kernel.org
          Reporter: guido.iodice@gmail.com
        Regression: No

After installing kernel 6.9rc5 it seems that all my f2fs partitions are
corrupted, according to fsck. On boot the check-repair is always performed. I
also tried running f2fs from a live usb (with kernel 6.6) but the problem is
not solved. Even running fsck several times always finds problems.

I attach the output of fsck -f -d 1 on one of the partitions.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #1 from Guido (guido.iodice@gmail.com) ---
Created attachment 306205
  --> https://bugzilla.kernel.org/attachment.cgi?id=306205&action=edit
fsck

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #2 from Artem S. Tashkinov (aros@gmx.com) ---
*** Bug 218769 has been marked as a duplicate of this bug. ***

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

Artem S. Tashkinov (aros@gmx.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |ANSWERED

--- Comment #3 from Artem S. Tashkinov (aros@gmx.com) ---
> Even running fsck several times always finds problems.

This looks like a f2fs fsck issue, not the kernel issue.

Please post here:

https://github.com/jaegeuk/f2fs-tools

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

Artem S. Tashkinov (aros@gmx.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|ANSWERED                    |CODE_FIX
         Regression|No                          |Yes

--- Comment #4 from Artem S. Tashkinov (aros@gmx.com) ---

On 4/24/24 12:21 PM, Tor Vic wrote:
> 
> I can confirm the constant fsck issue, and it was fixed in my case by 
> the following patch:
>
>
> https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaegeuk@kernel.org/

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #5 from Guido (guido.iodice@gmail.com) ---
(In reply to Artem S. Tashkinov from comment #4)
> On 4/24/24 12:21 PM, Tor Vic wrote:
> > 
> > I can confirm the constant fsck issue, and it was fixed in my case by 
> > the following patch:
> >
> >
> >
> https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaegeuk@kernel.org/

I have 6.9.rc5 (dated 2024-04-21 on kernel.org) Is that patch already applied
to it? If yes, it doesn't solve the bug.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[Tor Vic via Linux-f2fs-devel]

On 4/24/24 14:30, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=218770
> 
> --- Comment #5 from Guido (guido.iodice@gmail.com) ---
> (In reply to Artem S. Tashkinov from comment #4)
>> On 4/24/24 12:21 PM, Tor Vic wrote:
>>>
>>> I can confirm the constant fsck issue, and it was fixed in my case by
>>> the following patch:
>>>
>>>
>>>
>> https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaegeuk@kernel.org/
> 
> I have 6.9.rc5 (dated 2024-04-21 on kernel.org) Is that patch already applied
> to it? If yes, it doesn't solve the bug.
> 

No, not applied yet.


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[Tor Vic via Linux-f2fs-devel]

On 4/24/24 14:42, guido iodice wrote:
> Thank you.
> 
> For clarity, can you confirm that this is a false alarm and in fact there
> should be no corruption?

I'm not a developer, but my computer runs just fine with this patch 
applied since a week or so.

I didn't notice any data corruption or error messages in the log.

> 
> Best
> 
> ------------------------
> Guido Iodice
> 
> 
> 
> Il giorno mer 24 apr 2024 alle ore 14:40 Tor Vic <torvic9@mailbox.org> ha
> scritto:
> 
>>
>>
>> On 4/24/24 14:30, bugzilla-daemon@kernel.org wrote:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=218770
>>>
>>> --- Comment #5 from Guido (guido.iodice@gmail.com) ---
>>> (In reply to Artem S. Tashkinov from comment #4)
>>>> On 4/24/24 12:21 PM, Tor Vic wrote:
>>>>>
>>>>> I can confirm the constant fsck issue, and it was fixed in my case by
>>>>> the following patch:
>>>>>
>>>>>
>>>>>
>>>>
>> https://lore.kernel.org/linux-f2fs-devel/20240409203411.1885121-3-jaegeuk@kernel.org/
>>>
>>> I have 6.9.rc5 (dated 2024-04-21 on kernel.org) Is that patch already
>> applied
>>> to it? If yes, it doesn't solve the bug.
>>>
>>
>> No, not applied yet.
>>
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

Jaegeuk Kim (jaegeuk@kernel.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jaegeuk@kernel.org

--- Comment #6 from Jaegeuk Kim (jaegeuk@kernel.org) ---
Thank you for the report. It seems I need to reapply that patch indeed.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #7 from Guido (guido.iodice@gmail.com) ---
(In reply to Jaegeuk Kim from comment #6)
> Thank you for the report. It seems I need to reapply that patch indeed.

Does rc6 contain the reapplied patch?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #8 from Guido (guido.iodice@gmail.com) ---
The problem persists in the released version of kernel 6.9

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #9 from Jaegeuk Kim (jaegeuk@kernel.org) ---
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=b864ddb57eb00c4ea1e6801c7b2f70f1db2a7f4b

is going to be merged in upcoming weeks and LTS probably will pick up later
given the tag.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #10 from Guido (guido.iodice@gmail.com) ---
I applied the patch to 6.9 and it works fine. I am a bit surprised that it is
not already applied to 6.9.1.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #11 from Jaegeuk Kim (jaegeuk@kernel.org) ---
The patch is in the next pull request.
https://patchwork.kernel.org/project/f2fs/patch/ZkumXs7POGImbr-k@google.com/

Once Linus pulled it, I can ask Greg to queue it in -stable.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #12 from Guido (guido.iodice@gmail.com) ---
(In reply to Jaegeuk Kim from comment #11)
> The patch is in the next pull request.
> https://patchwork.kernel.org/project/f2fs/patch/ZkumXs7POGImbr-k@google.com/
> 
> Once Linus pulled it, I can ask Greg to queue it in -stable.

Thank you!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #13 from Jaegeuk Kim (jaegeuk@kernel.org) ---
6.9.2 will have the fix.

https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/?id=b863827181d80ae33f822dc74d32e377737858c2

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #14 from Guido (guido.iodice@gmail.com) ---
Thank you!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218770

--- Comment #15 from Jaegeuk Kim (jaegeuk@kernel.org) ---
correction; 6.9.3-rc1 has the fix.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel