[f2fs-dev] [Bug 218870] New: F2FS mount/unmount results in invalid_blkaddr

[f2fs-dev] [Bug 218870] New: F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

            Bug ID: 218870
           Summary: F2FS mount/unmount results in invalid_blkaddr
           Product: File System
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: f2fs
          Assignee: filesystem_f2fs@kernel-bugs.kernel.org
          Reporter: patrik.plihal@gmail.com
        Regression: No

At least 3 people hit an issue with f2fs mount taking a long time (due to
fsck).

In 2 cases it's is the boot partition which delays boot time, in my case it
simply delays a mount.


I prepared a example to reproduce the invalid_blkaddr (and which I presume is
the root cause for the long-mount/fsck)

  1. dd if=/dev/zero of=test.img count=100 bs=1M
  2. mkfs.f2fs -f ./test.img
  3. fsck.f2fs test.img  | grep errors # nothing
  4. mount -t f2fs ./test.img ./mnt
  5. umount ./test.img
  6. fsck.f2fs test.img  | grep errors 
    # Info: fs errors: invalid_blkaddr 


my initial comment / analysis started here:
https://bbs.archlinux.org/viewtopic.php?pid=2172855#p2172855

Linux blackbox 6.9.1-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 17 May 2024 16:56:38
+0000 x86_64 GNU/Linux

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

--- Comment #1 from Patrik Plihal (patrik.plihal@gmail.com) ---
It seems to not occur in 6.8.9 (can be downgraded + fsck reissued), I missed
this info initially.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

Paul Gover (pmw.gover@yahoo.co.uk) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pmw.gover@yahoo.co.uk

--- Comment #2 from Paul Gover (pmw.gover@yahoo.co.uk) ---
I can confirm the problem on my Gentoo system with a custom kernel.
As above, with the 6.8.9 kernel , no problems, but with the 6.9.1 kernel (same
configuration apart from a couple of new items resulting from "make oldconfig")
I get the invalid_blkaddr message and a full fsck.  That full fsck fails to fix
the problem, so the long boot occurs on all subsequent boots.

In my case I'm running "fsck.f2fs -f /dev/nvme0n1p3" from a shell script in my
home-rolled initramfs, using sys-fs/f2fs-tools-1.16.0-r1.

I'll put my log in an attachment.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

--- Comment #3 from Paul Gover (pmw.gover@yahoo.co.uk) ---
Created attachment 306325
  --> https://bugzilla.kernel.org/attachment.cgi?id=306325&action=edit
syslog showing the problem

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

Karol Kosek (krkk@serenityos.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krkk@serenityos.org

--- Comment #4 from Karol Kosek (krkk@serenityos.org) ---
Running git bisect told me this regressed in
31f85ccc84b82cc7eb122af01f5017fbe1e29289 "f2fs: unify the error handling of
f2fs_is_valid_blkaddr".

I haven't looked much into this commit, but reverting it on top on v6.9.1 sure
makes the error go away.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

Jaegeuk Kim (jaegeuk@kernel.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jaegeuk@kernel.org

--- Comment #5 from Jaegeuk Kim (jaegeuk@kernel.org) ---
Can you try 6.9.2 later?

https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/?id=b863827181d80ae33f822dc74d32e377737858c2

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

--- Comment #6 from George Sofianos (george@sofianos.dev) ---
I did try 6.9.2 (on Arch Linux) and still the same issue. Looking at the
commits
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/commit/?id=95d316e2c24a447e2b692c20f321ce7795527822
I think the patch didn't make it for 6.9.2 (unless I'm reading it wrong).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

--- Comment #7 from Jaegeuk Kim (jaegeuk@kernel.org) ---
Yeah.. I just saw that Greg queued it in 6.9.3-rc1.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

--- Comment #8 from Paul Gover (pmw.gover@yahoo.co.uk) ---
Just tried 6.9.3.
Appears the fix is now in and working - at least, I booted twice with a short
fsck, not the full works - so I'm currently a happy bunny.  Thanks.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [Bug 218870] F2FS mount/unmount results in invalid_blkaddr

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218870

Patrik Plihal (patrik.plihal@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |PATCH_ALREADY_AVAILABLE

--- Comment #9 from Patrik Plihal (patrik.plihal@gmail.com) ---
confirming that 6.9.3 (form arch's testing repos) mitigates the issue

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel