From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01D9CD2ECF7 for ; Tue, 20 Jan 2026 12:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KGSS3Ad+HVKNV+MnRKVX06B19tvJz2sxBdeZOECL06g=; b=jpcFzdJFxK9Wa4osKMpnPIMCD4 IqRFTX4z4wTnw9ZSu8mnoyNduDvE05uAWKb13XMIFF0SVD1BK7wmQYEJDuuniceePv9JGX6Bapzhq wHb+S61bRXRVGsyoQv2t4eNh+ltLvS/QpXONCbVEIn4wgwcAq2gePGtW3F1NpJPsP2/U=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1viAp9-0003Su-1M; Tue, 20 Jan 2026 12:27:07 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1viAp7-0003So-Iz for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Jan 2026 12:27:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Dhak6n/a8Q/VPjZVF4p8nn8NFlx+WLnUCMbcRAw3hRg=; b=LZ70rpwNreh2AVvgzo1n9jyFaU 80RzEwPkQKjc+ZSQC+c/WFKSpTV4j6IrXCdtj0uj0Ao3OQfQtt+0z5n2K7tDjh8hjhTU2jyUr7XFS 1ZbM3QBGKUxh3y8ax7T0Wjtb7gOfxZeTzIpAsW1gGGru00cbf3E/D1WTuIoB//md8eBU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Dhak6n/a8Q/VPjZVF4p8nn8NFlx+WLnUCMbcRAw3hRg=; b=bTkUUAYVhVK7Pc9ce1Nd8R5fHl XD6HVqcnWOwNQMz1ejjNgXPfh4eC8JQ/sJE8x2CNStT2t3FNlVWmci8EBfWq4SP+QQWiqT9fBuJN4 NCymgNZrkKQMYMkPOIeVUgm6NGyYJDxNB8AE+YV50qR7il14ubt5bGLHq2EUkLN4O8fo=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1viAp7-00023b-5O for linux-f2fs-devel@lists.sourceforge.net; Tue, 20 Jan 2026 12:27:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 746A260008; Tue, 20 Jan 2026 12:26:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD352C19422; Tue, 20 Jan 2026 12:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768912014; bh=VPEYyaKzDkDDZlF/oxtM8lm+/5HZ+Ypwfj1mXk9p7vU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=oUdYLWk4GWxOMMpCPLXxtCNBFgEdSj9p2ji0BomgayC1Qk7/UlfAxSqUU/I/A9ztX L9oC9o0itKB7cjGUD+dzBbxQwAKEQ+bO32FON7betl5+rMen3thQ4MRX4oS4MyYsIK ilyJsi7lS5oqDaDgdQBDJYJ4wOBKIFBG5QInq/t61xB3UNZKVEAgFG5nVFNznzqki4 xMGlwNei5MbSQE0ZI53csYVvZ7+ZNFKZqo12yzKjJSzf2SzjwHu26l+kzZoxLnrH1Q OxgFYjpVN8bxuHvfk9GrbNQ6ifF1XYhtzIEIbx4pHVSf37pdkhrDd3HFTW/ejJX1S4 ehMFzQj5gtFqg== Message-ID: Date: Tue, 20 Jan 2026 20:26:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: liujinbao1 , jaegeuk@kernel.org References: <20260114083705.944024-1-jinbaoliu365@gmail.com> Content-Language: en-US In-Reply-To: <20260114083705.944024-1-jinbaoliu365@gmail.com> X-Headers-End: 1viAp7-00023b-5O Subject: Re: [f2fs-dev] [PATCH v3] fsck.f2fs: Check and clear invalid dent flag during recovery X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: Yongpeng Yang , Sheng Yong , liujinbao1 , linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 1/14/2026 4:37 PM, liujinbao1 wrote: > From: liujinbao1 > > During SPO tests, when mounting F2FS, an -EINVAL error was returned. > The issue originates from the f2fs_recover_inode_page function's > check, where old_ni.blk_addr != NULL_ADDR under the conditions of > IS_INODE(folio) && is_dent_dnode(folio). > Clear dent flag of the node block to fix this issue. > Test Step: > 1.Modify files and induce SPO to generate fsync inode list. > blkaddr: 0x15828, ino: 1378, is_inode: 1, is_fsync: 2, is_dent: 0 > > 2.Use inject.f2fs to set dent flag for a fsync inode. > inject.f2fs --cp 0 --mb flag --idx 2 --val 7 /dev/vda > Info: inject blkaddr[2] flag of cp 2: 0x3 -> 0x7 > > 3.Boot verification, System fails to mount during recovery: > f2fs_recover_inode_page:ino: 1378, ni.blkaddr: 0x1581a, > old_ni.blk_addr != NULL_ADDR > F2FS-fs (vda): Cannot recover all fsync data errno=-22 > 4.Run fsck > fsck.f2fs -f /dev/vda > [ASSERT] (f2fs_find_fsync_inode:3924) --> Invalid dent flag: > blkaddr: 0x15828, ino: 1378, is_dent: 4, nat entry blkaddr: 0x1581a > [FIX] (f2fs_find_fsync_inode:3931) --> Clear dent flag: blkaddr: 0x15828, ino: 1378 > After this fix, the system boots normally. > > Signed-off-by: Sheng Yong > Signed-off-by: Yongpeng Yang > Signed-off-by: Jinbao Liu Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel