From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA249F47CBA for ; Thu, 5 Mar 2026 19:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To:Date:To: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=83jlj4hSyj5G122r/U7sHG/gqf5tLgvQ2rMUDB/bHt4=; b=ZncwDcjYTCwI5WFaNjMQOq5C0T F0jx+qwEx9CmP1GDmHfFLCfoNd63JIHnz1Dgfg9cgYNqCLMdBzaD6ShAnnjpsIhTTAGLAxWCwqDQ4 0tYirt2RNr8kS855GE3jOSCuGbFz9cKQ25Wom39lJwhUX/dZQqQ/PZ5bbKkwAjS/DlJs=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vyEKj-0001nZ-QN; Thu, 05 Mar 2026 19:26:05 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vyEKi-0001nE-4E; Thu, 05 Mar 2026 19:26:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=MIME-Version:Content-Transfer-Encoding:Content-Type :References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+V8en3UWdG4zZc5X//7Rm6lxG1GBlKF9AKNCra+DKHM=; b=KbNBGass8ebW7MrKFxsV4UsZYO /X9adFPbg8523hc0BPCAa3SGfFvQeDjUskftjrKCacLW48QrRw/Go2pE6ADqOIT3euxZrozTC05hY IsdTgNiWN8SEnKExBxXpiPPFD/QWSbkVRZPFVCfA/Puxb6d0j7w1VrOv8d5OO5arOvm8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+V8en3UWdG4zZc5X//7Rm6lxG1GBlKF9AKNCra+DKHM=; b=SVpEpU8TCFW/ug7YeOixS+bTuW xv1HXLNynw78wxzsep9HyAc/twpnAjTixH9F4j70pr1FT1zY8Y43E8/zEqKUbmXvpn05t0DwLzSwY G3ITCu/RbMlnROLY19BJpSEVvTuWPpkoy9XrvfAjD8+bghw71Kd6TAkuUZI+gV4HLQcA=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vyEKh-0002op-FM; Thu, 05 Mar 2026 19:26:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C4A5E41724; Thu, 5 Mar 2026 19:25:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35D37C116C6; Thu, 5 Mar 2026 19:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772738752; bh=vmlzEK3fLdHi0cfmhsSQFqvNzFA4ibJrsdtaMQ6FsMM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=TGM2saNldwviAIDLOQ1P8x7SOFo+tMXmvPb99Ysn3VNHwOFLT0Dhkqu45iWUuL7z3 LyYZ7qS4ipT3j1fgXJruoVMe0lYMx2J113EB9Q7XnMqjXPyaKkftQdmBZZDxeK/try VucQb2bczVK5Sy8w3LwHGwLHaz4q3c5zROVLu1JLYdaPjrfO6jLrmxU9WuGDL0e1LI sHnQE0ur6k+hc/akW5Ahil4lbe5t0rsnVRm5eLw8o0eC57sRaPKJgWj6ayg0q4hDq0 UIBUEOcDE/heTYNO07ncOYaV2Qsqr/pzwPBkNzbenDaZRszh71tzddVIzBoAx0CRXU b/biJfAV4c7KQ== Message-ID: To: Mike Snitzer Date: Thu, 05 Mar 2026 14:25:42 -0500 In-Reply-To: References: <20260108-setlease-6-20-v1-0-ea4dec9b67fa@kernel.org> <20260108-setlease-6-20-v1-24-ea4dec9b67fa@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) MIME-Version: 1.0 X-Headers-End: 1vyEKh-0002op-FM Subject: Re: [f2fs-dev] [PATCH 24/24] fs: remove simple_nosetlease() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jeff Layton via Linux-f2fs-devel Reply-To: Jeff Layton Cc: Latchesar Ionkov , Dave Kleikamp , Alexander Aring , Jan Kara , Paulo Alcantara , Sandeep Dhavale , Martin Brandenburg , Yuezhang Mo , Anders Larsen , Amir Goldstein , jfs-discussion@lists.sourceforge.net, linux-unionfs@vger.kernel.org, Konstantin Komarov , Chris Mason , Andreas Dilger , Chunhai Guo , Ilya Dryomov , Ronnie Sahlberg , linux-mtd@lists.infradead.org, Mike Marshall , linux-xfs@vger.kernel.org, Xiubo Li , Yue Hu , Miklos Szeredi , samba-technical@lists.samba.org, Richard Weinberger , Mark Fasheh , devel@lists.orangefs.org, Hugh Dickins , "Matthew Wilcox \(Oracle\)" , ntfs3@lists.linux.dev, Christoph Hellwig , Joseph Qi , linux-mm@kvack.org, Viacheslav Dubeyko , linux-btrfs@vger.kernel.org, Gao Xiang , linux-ext4@vger.kernel.org, Salah Triki , Carlos Maiolino , Dominique Martinet , Shyam Prasad N , Christian Schoenebeck , linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, Tom Talpey , ocfs2-devel@lists.linux.dev, Bharath SM , linux-nilfs@vger.kernel.org, David Sterba , Alexander Viro , Baolin Wang , Jeffle Xu , Jaegeuk Kim , ceph-devel@vger.kernel.org, Eric Van Hensbergen , Ryusuke Konishi , OGAWA Hirofumi , Andreas Gruenbacher , Hans de Goede , gfs2@lists.linux.dev, Christian Brauner , linux-f2fs-devel@lists.sourceforge.net, Theodore Ts'o , Luis de Bethencourt , Nicolas Pitre , linux-erofs@lists.ozlabs.org, v9fs@lists.linux.dev, Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Steve French , Chuck Lever , Hongbo Li , Anna Schumaker , Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , Andrew Morton , Sungjong Seo , David Woodhouse , Trond Myklebust , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, 2026-03-04 at 17:29 -0500, Mike Snitzer wrote: > On Wed, Mar 04, 2026 at 11:59:32AM -0500, Jeff Layton wrote: > > On Wed, 2026-02-25 at 12:58 -0500, Mike Snitzer wrote: > > > On Thu, Jan 08, 2026 at 12:13:19PM -0500, Jeff Layton wrote: > > > > Setting ->setlease() to a NULL pointer now has the same effect as > > > > setting it to simple_nosetlease(). Remove all of the setlease > > > > file_operations that are set to simple_nosetlease, and the function > > > > itself. > > > > > > > > Signed-off-by: Jeff Layton > > > > --- > > > > fs/9p/vfs_dir.c | 2 -- > > > > fs/9p/vfs_file.c | 2 -- > > > > fs/ceph/dir.c | 2 -- > > > > fs/ceph/file.c | 1 - > > > > fs/fuse/dir.c | 1 - > > > > fs/gfs2/file.c | 2 -- > > > > fs/libfs.c | 18 ------------------ > > > > fs/nfs/dir.c | 1 - > > > > fs/nfs/file.c | 1 - > > > > fs/smb/client/cifsfs.c | 1 - > > > > fs/vboxsf/dir.c | 1 - > > > > fs/vboxsf/file.c | 1 - > > > > include/linux/fs.h | 1 - > > > > 13 files changed, 34 deletions(-) > > > > > > > > > > > > > > > > > diff --git a/fs/libfs.c b/fs/libfs.c > > > > index 697c6d5fc12786c036f0086886297fb5cd52ae00..f1860dff86f2703266beecf31e9d2667af7a9684 100644 > > > > --- a/fs/libfs.c > > > > +++ b/fs/libfs.c > > > > @@ -1699,24 +1699,6 @@ struct inode *alloc_anon_inode(struct super_block *s) > > > > } > > > > EXPORT_SYMBOL(alloc_anon_inode); > > > > > > > > -/** > > > > - * simple_nosetlease - generic helper for prohibiting leases > > > > - * @filp: file pointer > > > > - * @arg: type of lease to obtain > > > > - * @flp: new lease supplied for insertion > > > > - * @priv: private data for lm_setup operation > > > > - * > > > > - * Generic helper for filesystems that do not wish to allow leases to be set. > > > > - * All arguments are ignored and it just returns -EINVAL. > > > > - */ > > > > -int > > > > -simple_nosetlease(struct file *filp, int arg, struct file_lease **flp, > > > > - void **priv) > > > > -{ > > > > - return -EINVAL; > > > > -} > > > > -EXPORT_SYMBOL(simple_nosetlease); > > > > - > > > > /** > > > > * simple_get_link - generic helper to get the target of "fast" symlinks > > > > * @dentry: not used here > > > > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > > > > index 71df279febf797880ded19e45528c3df4cea2dde..23a78a742b619dea8b76ddf28f4f59a1c8a015e2 100644 > > > > --- a/fs/nfs/dir.c > > > > +++ b/fs/nfs/dir.c > > > > @@ -66,7 +66,6 @@ const struct file_operations nfs_dir_operations = { > > > > .open = nfs_opendir, > > > > .release = nfs_closedir, > > > > .fsync = nfs_fsync_dir, > > > > - .setlease = simple_nosetlease, > > > > }; > > > > > > > > const struct address_space_operations nfs_dir_aops = { > > > > diff --git a/fs/nfs/file.c b/fs/nfs/file.c > > > > index d020aab40c64ebda30d130b6acee1b9194621457..9d269561961825f88529551b0f0287920960ac62 100644 > > > > --- a/fs/nfs/file.c > > > > +++ b/fs/nfs/file.c > > > > @@ -962,7 +962,6 @@ const struct file_operations nfs_file_operations = { > > > > .splice_read = nfs_file_splice_read, > > > > .splice_write = iter_file_splice_write, > > > > .check_flags = nfs_check_flags, > > > > - .setlease = simple_nosetlease, > > > > .fop_flags = FOP_DONTCACHE, > > > > }; > > > > EXPORT_SYMBOL_GPL(nfs_file_operations); > > > > > > Hey Jeff, > > > > > > I've noticed an NFS reexport regression in v6.19 and now v7.0-rc1 > > > (similar but different due to your series that requires opt-in via > > > .setlease). > > > > > > Bisect first pointed out this commit: > > > 10dcd5110678 nfs: properly disallow delegation requests on directories > > > > > > And now with v7.0-rc1 its the fact that NFS doesn't provide .setlease > > > so lstat() on parent dir (of file that I touch) gets -EINVAL. > > > > > > So its a confluence of NFS's dir delegations and your setlease changes. > > > > > > If I reexport NFSv4.2 filesystem in terms of NFSv4.1, the regression > > > is seen by doing (lstat reproducer that gemini spit out for me is > > > attached): > > > > > > $ touch /mnt/share41/test > > > $ strace ./lstat /mnt/share41 > > > ... > > > lstat("/mnt/share41", 0x7ffec0d79920) = -1 EINVAL (Invalid argument) > > > > > > If I immediately re-run it works: > > > ... > > > lstat("/mnt/share41", {st_mode=S_IFDIR|0777, st_size=4096, ...}) = 0 > > > > > > I'm not sure what the proper fix is yet, but I feel like you've missed > > > that NFS itself can be (re)exported? > > > > > > > > > > My apologies. I missed seeing this last week. > > > > That's a very simple reproducer! That's very strange behavior, > > especially since NFS4 does provide a setlease operation: > > > > const struct file_operations nfs4_file_operations = { > > [...] > > .setlease = nfs4_setlease, > > [...] > > }; > > Huh, not sure how I missed nfs4_setlease... > > > I'm not sure why this would cause lstat() to return -EINVAL. > > Likewise, especially given nfs4_setlease > > > What's happening on the wire when this occurs? > > > > I'll plan to take a look here soon either way. > > I'll have to revisit myself, been a bit. > > Will let you know. > Thanks. I just tested your reproducer. I have a nfsv4.2 mount on one host that is reexported, and mounted the reexport on a different host with "-o vers=4.1". It seems to work for me. It's possible I don't have something set up the same way though: $ touch /mnt/scratch/test ; ./lstat /mnt/scratch/test Information for: /mnt/scratch/test --------------------------- File Size: 0 bytes Number of Links: 1 File inode: 272 File Type: Regular File -- Jeff Layton _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel