From: Chao Yu <chao@kernel.org>
To: Yangtao Li <frank.li@vivo.com>, s.shtylyov@omp.ru
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()
Date: Wed, 21 Dec 2022 20:34:13 +0800 [thread overview]
Message-ID: <c532ee2b-66bb-9227-ebd7-a070599fe3ae@kernel.org> (raw)
In-Reply-To: <20221221033021.36615-1-frank.li@vivo.com>
Hi all,
On 2022/12/21 11:30, Yangtao Li wrote:
> Hi Sergey,
>
>> In expand_inode_data(), the 'new_size' local variable is initialized to
>> the result of i_size_read(), however this value isn't ever used, so we
>> can drop this initializer...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> ---
>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>> Reposting with ISP RAS mailing lists CC'ed now...
>
> Why do you repeatedly send a patch that cannot be applied, and this does not have
The format is weired, but still I can apply this into my git repo...
> a CC on linux-kernel.vger.kernel.org.
I guess linux-kernel.vger.kernel.org is not mandatory, feel free
to Cc this mailing list.
Thanks,
>
> Otherwise, code modification looks good to me.
>
> Thx,
> Yangtao
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-12-21 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 3:30 [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data() Yangtao Li via Linux-f2fs-devel
2022-12-21 12:34 ` Chao Yu [this message]
2022-12-21 14:55 ` Sergey Shtylyov
2022-12-21 14:46 ` Sergey Shtylyov
2022-12-21 14:50 ` Sergey Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2022-12-20 17:17 Sergey Shtylyov
2022-12-21 12:22 ` Chao Yu
2023-01-09 22:51 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c532ee2b-66bb-9227-ebd7-a070599fe3ae@kernel.org \
--to=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).