From: David Laight <David.Laight@ACULAB.COM>
To: 'Jan Kara' <jack@suse.cz>, Christian Brauner <brauner@kernel.org>
Cc: Ted Tso <tytso@mit.edu>, Miklos Szeredi <miklos@szeredi.hu>,
"Darrick J. Wong" <djwong@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH v2 4/6] fs: Establish locking order for unrelated directories
Date: Thu, 1 Jun 2023 15:37:32 +0000 [thread overview]
Message-ID: <c5f209a6263b4f039c5eafcafddf90ca@AcuMS.aculab.com> (raw)
In-Reply-To: <20230601152449.h4ur5zrfqjqygujd@quack3>
...
> > > + * Lock any non-NULL argument. The caller must make sure that if he is passing
> > > + * in two directories, one is not ancestor of the other
Not directly relevant to this change but is the 'not an ancestor'
check actually robust?
I found a condition in which the kernel 'pwd' code (which follows
the inode chain) failed to stop at the base of a chroot.
I suspect that the ancestor check would fail the same way.
IIRC the problematic code used unshare() to 'escape' from
a network natespace.
If it was inside a chroot (that wasn't on a mount point) there
ware two copies of the 'chroot /' inode and the match failed.
I might be able to find the test case.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-06-01 15:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 10:58 [f2fs-dev] [PATCH v2 0/6] fs: Fix directory corruption when moving directories Jan Kara
2023-06-01 10:58 ` [f2fs-dev] [PATCH v2 1/6] ext4: Remove ext4 locking of moved directory Jan Kara
2023-06-01 14:52 ` Theodore Ts'o
2023-06-01 15:27 ` Jan Kara
2023-06-01 15:58 ` Christian Brauner
2023-06-01 10:58 ` [f2fs-dev] [PATCH v2 2/6] Revert "udf: Protect rename against modification of moved directory" Jan Kara
2023-06-01 10:58 ` [f2fs-dev] [PATCH v2 3/6] Revert "f2fs: fix potential corruption when moving a directory" Jan Kara
2023-06-01 10:58 ` [f2fs-dev] [PATCH v2 4/6] fs: Establish locking order for unrelated directories Jan Kara
2023-06-01 13:58 ` Christian Brauner
2023-06-01 15:24 ` Jan Kara
2023-06-01 15:37 ` David Laight [this message]
2023-06-01 16:13 ` Jan Kara
2023-06-01 16:21 ` Christian Brauner
2023-06-01 16:33 ` David Laight
2023-06-02 12:34 ` Christian Brauner
2023-06-01 15:59 ` Christian Brauner
2023-06-02 1:36 ` kernel test robot
2023-06-01 10:58 ` [f2fs-dev] [PATCH v2 5/6] fs: Lock moved directories Jan Kara
2023-06-01 10:58 ` [f2fs-dev] [PATCH v2 6/6] fs: Restrict lock_two_nondirectories() to non-directory inodes Jan Kara
2023-06-02 13:05 ` [f2fs-dev] [PATCH v2 0/6] fs: Fix directory corruption when moving directories Christian Brauner
2023-07-06 0:18 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5f209a6263b4f039c5eafcafddf90ca@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).