From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH] mkfs.f2fs: show the info of volume label only when specify it Date: Mon, 15 Oct 2018 20:08:08 +0800 Message-ID: References: <7d9354b8.ca7b.16653b02e86.Coremail.kernelpatch@126.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gC1fZ-0007O6-LV for linux-f2fs-devel@lists.sourceforge.net; Mon, 15 Oct 2018 12:08:21 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1gC1fX-001wNf-Hq for linux-f2fs-devel@lists.sourceforge.net; Mon, 15 Oct 2018 12:08:21 +0000 In-Reply-To: <7d9354b8.ca7b.16653b02e86.Coremail.kernelpatch@126.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Tiezhu Yang , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net On 2018/10/8 20:39, Tiezhu Yang wrote: > Currently, when format disk used with mkfs.f2fs, even if the volume label > is not specified, it still shows the info of volume label with no content > due to the check condition is always true, this patch fixes it. > > [root@localhost home]# mkfs.f2fs -f /dev/sdb1 > > F2FS-tools: mkfs.f2fs Ver: 1.12.0 (2018-10-08) > > Info: Disable heap-based policy > Info: Debug level = 0 > Info: Label = > Info: Trim is enabled Like tune2fs does, we can show volume label as below if user didn't set it. Info: Label = Thanks, > > Signed-off-by: Tiezhu Yang > --- > mkfs/f2fs_format_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c > index 1424cc3..6ea8068 100644 > --- a/mkfs/f2fs_format_main.c > +++ b/mkfs/f2fs_format_main.c > @@ -81,7 +81,7 @@ static void f2fs_show_info() > if (c.extension_list[1]) > MSG(0, "Info: Add new hot file extension list\n"); > > - if (c.vol_label) > + if (strlen(c.vol_label)) > MSG(0, "Info: Label = %s\n", c.vol_label); > MSG(0, "Info: Trim is %s\n", c.trim ? "enabled": "disabled"); > >