From: Chao Yu <chao@kernel.org>
To: Yunlong Song <yunlong.song@huawei.com>,
jaegeuk@kernel.org, yuchao0@huawei.com, sylinux@163.com
Cc: miaoxie@huawei.com, bintian.wang@huawei.com,
linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: no need to create issue_discard_thread if it exists
Date: Thu, 6 Jul 2017 21:16:19 +0800 [thread overview]
Message-ID: <c76a5045-078b-1018-23f8-ccfaefa6f2b4@kernel.org> (raw)
In-Reply-To: <1499339134-104480-1-git-send-email-yunlong.song@huawei.com>
Hi Yunlong,
It looks there is no way to create discard thread redundantly,
so here we don't need to check this?
Thanks,
On 2017/7/6 19:05, Yunlong Song wrote:
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> fs/f2fs/segment.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 4c246e3..b48d004 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1417,6 +1417,8 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
>
> if (SM_I(sbi)->dcc_info) {
> dcc = SM_I(sbi)->dcc_info;
> + if (dcc->f2fs_issue_discard)
> + return err;
> goto init_thread;
> }
>
>
next prev parent reply other threads:[~2017-07-06 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 11:05 [PATCH] f2fs: no need to create issue_discard_thread if it exists Yunlong Song
2017-07-06 13:16 ` Chao Yu [this message]
2017-07-07 2:02 ` Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c76a5045-078b-1018-23f8-ccfaefa6f2b4@kernel.org \
--to=chao@kernel.org \
--cc=bintian.wang@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=sylinux@163.com \
--cc=yuchao0@huawei.com \
--cc=yunlong.song@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).