[f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[Sergey Shtylyov]

In expand_inode_data(), the 'new_size' local variable is initialized to
the result of i_size_read(), however this value isn't ever used,  so we
can drop this initializer...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

---
This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
Reposting with ISP RAS mailing lists CC'ed now...

 fs/f2fs/file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: f2fs/fs/f2fs/file.c
===================================================================
--- f2fs.orig/fs/f2fs/file.c
+++ f2fs/fs/f2fs/file.c
@@ -1697,7 +1697,7 @@ static int expand_inode_data(struct inod
 			.err_gc_skipped = true,
 			.nr_free_secs = 0 };
 	pgoff_t pg_start, pg_end;
-	loff_t new_size = i_size_read(inode);
+	loff_t new_size;
 	loff_t off_end;
 	block_t expanded = 0;
 	int err;


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[Chao Yu]

On 2022/12/21 1:17, Sergey Shtylyov wrote:
> In expand_inode_data(), the 'new_size' local variable is initialized to
> the result of i_size_read(), however this value isn't ever used,  so we
> can drop this initializer...
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[patchwork-bot+f2fs]

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Tue, 20 Dec 2022 20:17:32 +0300 you wrote:
> In expand_inode_data(), the 'new_size' local variable is initialized to
> the result of i_size_read(), however this value isn't ever used,  so we
> can drop this initializer...
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
> 
> [...]

Here is the summary with links:
  - [f2fs-dev,REPOST] f2fs: file: drop useless initializer in expand_inode_data()
    https://git.kernel.org/jaegeuk/f2fs/c/39bee2e6acc2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[Yangtao Li via Linux-f2fs-devel]

Hi Sergey,

> In expand_inode_data(), the 'new_size' local variable is initialized to
> the result of i_size_read(), however this value isn't ever used,  so we
> can drop this initializer...
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> 
> ---
> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
> Reposting with ISP RAS mailing lists CC'ed now...

Why do you repeatedly send a patch that cannot be applied, and this does not have
a CC on linux-kernel.vger.kernel.org.

Otherwise, code modification looks good to me.

Thx,
Yangtao


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[Chao Yu]

Hi all,

On 2022/12/21 11:30, Yangtao Li wrote:
> Hi Sergey,
> 
>> In expand_inode_data(), the 'new_size' local variable is initialized to
>> the result of i_size_read(), however this value isn't ever used,  so we
>> can drop this initializer...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> ---
>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>> Reposting with ISP RAS mailing lists CC'ed now...
> 
> Why do you repeatedly send a patch that cannot be applied, and this does not have

The format is weired, but still I can apply this into my git repo...

> a CC on linux-kernel.vger.kernel.org.

I guess linux-kernel.vger.kernel.org is not mandatory, feel free
to Cc this mailing list.

Thanks,

> 
> Otherwise, code modification looks good to me.
> 
> Thx,
> Yangtao


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[Sergey Shtylyov]

On 12/21/22 3:34 PM, Chao Yu wrote:

[...]
>>> In expand_inode_data(), the 'new_size' local variable is initialized to
>>> the result of i_size_read(), however this value isn't ever used,  so we
>>> can drop this initializer...
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>>> analysis tool.
>>>
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>>
>>> ---
>>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>>> Reposting with ISP RAS mailing lists CC'ed now...
>>
>> Why do you repeatedly send a patch that cannot be applied, and this does not have
> 
> The format is weired, but still I can apply this into my git repo...

   This is just the quilt's format. I normally use quilt for development
and then import my patch seies to git in order to prepare it for posting.
If I post a single patch, I just skip the git step and post with my MTA...

[...]

>> Thx,
>> Yangtao

MBR, Sergey


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[Sergey Shtylyov]

Hello!

On 12/21/22 6:30 AM, Yangtao Li wrote:

>> In expand_inode_data(), the 'new_size' local variable is initialized to
>> the result of i_size_read(), however this value isn't ever used,  so we
>> can drop this initializer...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> ---
>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>> Reposting with ISP RAS mailing lists CC'ed now...
> 
> Why do you repeatedly send a patch that cannot be applied,

   Why (it does apply to your 'dev' branch)? Because of the merge window?

> and this does not have a CC on linux-kernel.vger.kernel.org.

   I normnally avoid CCing LKML as my patches are not generally interesting
to the wide public (I think)...

> Otherwise, code modification looks good to me.

   Thanx!

> Thx,
> Yangtao

MBR, Sergey


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()

[Sergey Shtylyov]

On 12/21/22 5:46 PM, Sergey Shtylyov wrote:

>>> In expand_inode_data(), the 'new_size' local variable is initialized to
>>> the result of i_size_read(), however this value isn't ever used,  so we
>>> can drop this initializer...
>>>
>>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>>> analysis tool.
>>>
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>>
>>> ---
>>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>>> Reposting with ISP RAS mailing lists CC'ed now...
>>
>> Why do you repeatedly send a patch

   Sorry, 1st time I forgot to do the internal CC dance -- CCing couple SVACE
(static analyzer) specific mailing lists...

[...]

>> Thx,
>> Yangtao

MBR, Sergey


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel