* [f2fs-dev] [PATCH 2/5] f2fs_io: measure atomic operation latency with random write
  2025-09-30  2:37 [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency Jaegeuk Kim via Linux-f2fs-devel
@ 2025-09-30  2:37 ` Jaegeuk Kim via Linux-f2fs-devel
  2025-10-09  2:38   ` Chao Yu via Linux-f2fs-devel
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 3/5] f2fs_io: add mlock to measure the read speed Jaegeuk Kim via Linux-f2fs-devel
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Jaegeuk Kim via Linux-f2fs-devel @ 2025-09-30  2:37 UTC (permalink / raw)
  To: linux-f2fs-devel; +Cc: Jaegeuk Kim
If we give a negative offset, let's do random writes.
> f2fs_io write 1 -400 10 rand atomic_commit ./test
conducts 10 random writes by picking addresses between 0 and
400 * 4KB.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 tools/f2fs_io/f2fs_io.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
index 1f6bfcfff556..b9bf9bc5f797 100644
--- a/tools/f2fs_io/f2fs_io.c
+++ b/tools/f2fs_io/f2fs_io.c
@@ -710,7 +710,8 @@ static void do_write_with_advice(int argc, char **argv,
 			const struct cmd_desc *cmd, bool with_advice)
 {
 	u64 buf_size = 0, inc_num = 0, written = 0;
-	u64 offset;
+	u64 offset, offset_byte;
+	bool random_offset = false;
 	char *buf = NULL;
 	unsigned bs, count, i;
 	int flags = 0;
@@ -727,7 +728,11 @@ static void do_write_with_advice(int argc, char **argv,
 
 	buf_size = bs * F2FS_DEFAULT_BLKSIZE;
 
-	offset = atoi(argv[2]) * buf_size;
+	offset = atoi(argv[2]);
+	if (atoi(argv[2]) < 0) {
+		random_offset = true;
+		offset = -offset;
+	}
 
 	buf = aligned_xalloc(F2FS_DEFAULT_BLKSIZE, buf_size);
 	count = atoi(argv[3]);
@@ -812,10 +817,14 @@ static void do_write_with_advice(int argc, char **argv,
 		else if (!strcmp(argv[4], "rand"))
 			*(int *)buf = rand();
 
+		offset_byte = (random_offset ? rand() % offset :
+				offset + i) * buf_size;
+
 		/* write data */
 		max_time_t = get_current_us();
-		ret = pwrite(fd, buf, buf_size, offset + buf_size * i);
+		ret = pwrite(fd, buf, buf_size, offset_byte);
 		max_time_t = get_current_us() - max_time_t;
+
 		if (max_time < max_time_t)
 			max_time = max_time_t;
 		if (ret != buf_size)
@@ -844,7 +853,7 @@ static void do_write_with_advice(int argc, char **argv,
 		}
 	}
 
-	printf("Written %"PRIu64" bytes with pattern=%s, total_time=%"PRIu64" us, max_latency=%"PRIu64" us\n",
+	printf("Written %"PRIu64" bytes with pattern = %s, total_time = %"PRIu64" us, max_latency = %"PRIu64" us\n",
 				written, argv[4],
 				get_current_us() - total_time,
 				max_time);
@@ -855,6 +864,8 @@ static void do_write_with_advice(int argc, char **argv,
 #define write_help					\
 "f2fs_io write [chunk_size in 4kb] [offset in chunk_size] [count] [pattern] [IO] [file_path] {delay}\n\n"	\
 "Write given patten data in file_path\n"		\
+"Offset can be a negative number which\n"		\
+"  indicates random write range for atomic operations.\n" \
 "pattern can be\n"					\
 "  zero          : zeros\n"				\
 "  inc_num       : incrementing numbers\n"		\
-- 
2.51.0.618.g983fd99d29-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related	[flat|nested] 10+ messages in thread* [f2fs-dev] [PATCH 3/5] f2fs_io: add mlock to measure the read speed
  2025-09-30  2:37 [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency Jaegeuk Kim via Linux-f2fs-devel
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 2/5] f2fs_io: measure atomic operation latency with random write Jaegeuk Kim via Linux-f2fs-devel
@ 2025-09-30  2:37 ` Jaegeuk Kim via Linux-f2fs-devel
  2025-10-09  2:40   ` Chao Yu via Linux-f2fs-devel
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 4/5] f2fs_io: add dontcache to measure RWF_DONTCACHE speed Jaegeuk Kim via Linux-f2fs-devel
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Jaegeuk Kim via Linux-f2fs-devel @ 2025-09-30  2:37 UTC (permalink / raw)
  To: linux-f2fs-devel; +Cc: Jaegeuk Kim
Add missing mmap mode in man page.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 man/f2fs_io.8           |  6 ++++++
 tools/f2fs_io/f2fs_io.c | 34 +++++++++++++++++++++++++++-------
 2 files changed, 33 insertions(+), 7 deletions(-)
diff --git a/man/f2fs_io.8 b/man/f2fs_io.8
index 6f3e11e96ed6..8e54aa644a00 100644
--- a/man/f2fs_io.8
+++ b/man/f2fs_io.8
@@ -127,6 +127,12 @@ buffered I/O
 .TP
 .B dio
 direct I/O
+.TP
+.B mmap
+mmap(MAP_POPULATE)
+.TP
+.B mlock
+mmap() + mlock()
 .RE
 .TP
 \fBfiemap\fR \fI[offset in 4kb] [count] [file_path]\fR
diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
index b9bf9bc5f797..028ffe59d0c7 100644
--- a/tools/f2fs_io/f2fs_io.c
+++ b/tools/f2fs_io/f2fs_io.c
@@ -931,6 +931,7 @@ static void do_write_advice(int argc, char **argv, const struct cmd_desc *cmd)
 "  buffered : buffered IO\n"				\
 "  dio      : direct IO\n"				\
 "  mmap     : mmap IO\n"				\
+"  mlock    : mmap + mlock\n"				\
 "advice can be\n"					\
 " 1 : set sequential|willneed\n"			\
 " 0 : none\n"						\
@@ -940,12 +941,13 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 	u64 buf_size = 0, ret = 0, read_cnt = 0;
 	u64 offset;
 	char *buf = NULL;
-	char *data;
+	char *data = NULL;
 	char *print_buf = NULL;
 	unsigned bs, count, i, print_bytes;
 	u64 total_time = 0;
 	int flags = 0;
 	int do_mmap = 0;
+	int do_mlock = 0;
 	int fd, advice;
 
 	if (argc != 8) {
@@ -968,6 +970,8 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 		flags |= O_DIRECT;
 	else if (!strcmp(argv[4], "mmap"))
 		do_mmap = 1;
+	else if (!strcmp(argv[4], "mlock"))
+		do_mlock = 1;
 	else if (strcmp(argv[4], "buffered"))
 		die("Wrong IO type");
 
@@ -993,11 +997,24 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 	total_time = get_current_us();
 	if (do_mmap) {
 		data = mmap(NULL, count * buf_size, PROT_READ,
-						MAP_SHARED | MAP_POPULATE, fd, offset);
+				MAP_SHARED | MAP_POPULATE, fd, offset);
 		if (data == MAP_FAILED)
 			die("Mmap failed");
-	}
-	if (!do_mmap) {
+
+		read_cnt = count * buf_size;
+		memcpy(print_buf, data, print_bytes);
+	} else if (do_mlock) {
+		data = mmap(NULL, count * buf_size, PROT_READ,
+				MAP_SHARED, fd, offset);
+		if (data == MAP_FAILED)
+			die("Mmap failed");
+		if (posix_fadvise(fd, offset, count * buf_size,
+					POSIX_FADV_WILLNEED) != 0)
+			die_errno("fadvise failed");
+		if (mlock(data, count * buf_size))
+			die_errno("mlock failed");
+		read_cnt = count * buf_size;
+	} else {
 		for (i = 0; i < count; i++) {
 			ret = pread(fd, buf, buf_size, offset + buf_size * i);
 			if (ret != buf_size) {
@@ -1014,9 +1031,6 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 			if (i == 0)
 				memcpy(print_buf, buf, print_bytes);
 		}
-	} else {
-		read_cnt = count * buf_size;
-		memcpy(print_buf, data, print_bytes);
 	}
 	printf("Read %"PRIu64" bytes total_time = %"PRIu64" us, BW = %.Lf MB/s print %u bytes:\n",
 		read_cnt, get_current_us() - total_time,
@@ -1029,6 +1043,12 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 		else if (i % 2 == 0)
 			printf(" ");
 	}
+	if (do_mmap) {
+		munmap(data, count * buf_size);
+	} else if (do_mlock) {
+		munlock(data, count * buf_size);
+		munmap(data, count * buf_size);
+	}
 	printf("\n");
 	exit(0);
 }
-- 
2.51.0.618.g983fd99d29-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related	[flat|nested] 10+ messages in thread* [f2fs-dev] [PATCH 4/5] f2fs_io: add dontcache to measure RWF_DONTCACHE speed
  2025-09-30  2:37 [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency Jaegeuk Kim via Linux-f2fs-devel
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 2/5] f2fs_io: measure atomic operation latency with random write Jaegeuk Kim via Linux-f2fs-devel
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 3/5] f2fs_io: add mlock to measure the read speed Jaegeuk Kim via Linux-f2fs-devel
@ 2025-09-30  2:37 ` Jaegeuk Kim via Linux-f2fs-devel
  2025-10-09  2:41   ` Chao Yu via Linux-f2fs-devel
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 5/5] f2fs_io: let's try to get contigous memory if possible Jaegeuk Kim via Linux-f2fs-devel
  2025-10-09  2:30 ` [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency Chao Yu via Linux-f2fs-devel
  4 siblings, 1 reply; 10+ messages in thread
From: Jaegeuk Kim via Linux-f2fs-devel @ 2025-09-30  2:37 UTC (permalink / raw)
  To: linux-f2fs-devel; +Cc: Jaegeuk Kim
It only measures the read performance.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 configure.ac            |  1 +
 man/f2fs_io.8           |  3 +++
 tools/f2fs_io/f2fs_io.c | 19 ++++++++++++++++++-
 tools/f2fs_io/f2fs_io.h |  4 ++++
 4 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index ddfc3b0f30e2..4d91605f8106 100644
--- a/configure.ac
+++ b/configure.ac
@@ -194,6 +194,7 @@ AC_CHECK_FUNCS_ONCE([
 	keyctl
 	memset
 	pread
+	preadv2
 	pwrite
 	setmntent
 ])
diff --git a/man/f2fs_io.8 b/man/f2fs_io.8
index 8e54aa644a00..708a5831bba0 100644
--- a/man/f2fs_io.8
+++ b/man/f2fs_io.8
@@ -125,6 +125,9 @@ options can be:
 .B buffered
 buffered I/O
 .TP
+.B dontcache
+buffered I/O with RWF_DONTCACHE
+.TP
 .B dio
 direct I/O
 .TP
diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
index 028ffe59d0c7..22f9968a35e9 100644
--- a/tools/f2fs_io/f2fs_io.c
+++ b/tools/f2fs_io/f2fs_io.c
@@ -24,6 +24,8 @@
 #include <linux/fs.h>
 #include <signal.h>
 #include <stdarg.h>
+#include <sys/uio.h>
+#include <stdarg.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -929,6 +931,7 @@ static void do_write_advice(int argc, char **argv, const struct cmd_desc *cmd)
 "Read data in file_path and print nbytes\n"		\
 "IO can be\n"						\
 "  buffered : buffered IO\n"				\
+"  dontcache: buffered IO + dontcache\n"		\
 "  dio      : direct IO\n"				\
 "  mmap     : mmap IO\n"				\
 "  mlock    : mmap + mlock\n"				\
@@ -948,6 +951,7 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 	int flags = 0;
 	int do_mmap = 0;
 	int do_mlock = 0;
+	int do_dontcache = 0;
 	int fd, advice;
 
 	if (argc != 8) {
@@ -972,6 +976,12 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 		do_mmap = 1;
 	else if (!strcmp(argv[4], "mlock"))
 		do_mlock = 1;
+	else if (!strcmp(argv[4], "dontcache"))
+#ifdef HAVE_PREADV2
+		do_dontcache = 1;
+#else
+		die("Not support - preadv2");
+#endif
 	else if (strcmp(argv[4], "buffered"))
 		die("Wrong IO type");
 
@@ -1016,7 +1026,14 @@ static void do_read(int argc, char **argv, const struct cmd_desc *cmd)
 		read_cnt = count * buf_size;
 	} else {
 		for (i = 0; i < count; i++) {
-			ret = pread(fd, buf, buf_size, offset + buf_size * i);
+			if (!do_dontcache) {
+				ret = pread(fd, buf, buf_size, offset + buf_size * i);
+			} else {
+#ifdef HAVE_PREADV2
+				struct iovec iov = { .iov_base = buf, .iov_len = buf_size };
+				ret = preadv2(fd, &iov, 1, offset + buf_size * i, RWF_DONTCACHE);
+#endif
+			}
 			if (ret != buf_size) {
 				printf("pread expected: %"PRIu64", readed: %"PRIu64"\n",
 						buf_size, ret);
diff --git a/tools/f2fs_io/f2fs_io.h b/tools/f2fs_io/f2fs_io.h
index 21fd3864a20d..b0d40996f302 100644
--- a/tools/f2fs_io/f2fs_io.h
+++ b/tools/f2fs_io/f2fs_io.h
@@ -226,6 +226,10 @@ enum {
 #define FS_CASEFOLD_FL			0x40000000 /* Folder is case insensitive */
 #endif
 
+#ifndef RWF_DONTCACHE
+#define RWF_DONTCACHE			0x00000080 /* Uncached buffered IO.  */
+#endif
+
 struct f2fs_gc_range {
 	u32 sync;
 	u64 start;
-- 
2.51.0.618.g983fd99d29-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related	[flat|nested] 10+ messages in thread* [f2fs-dev] [PATCH 5/5] f2fs_io: let's try to get contigous memory if possible
  2025-09-30  2:37 [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency Jaegeuk Kim via Linux-f2fs-devel
                   ` (2 preceding siblings ...)
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 4/5] f2fs_io: add dontcache to measure RWF_DONTCACHE speed Jaegeuk Kim via Linux-f2fs-devel
@ 2025-09-30  2:37 ` Jaegeuk Kim via Linux-f2fs-devel
  2025-10-09  2:44   ` Chao Yu via Linux-f2fs-devel
  2025-10-09  2:30 ` [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency Chao Yu via Linux-f2fs-devel
  4 siblings, 1 reply; 10+ messages in thread
From: Jaegeuk Kim via Linux-f2fs-devel @ 2025-09-30  2:37 UTC (permalink / raw)
  To: linux-f2fs-devel; +Cc: Jaegeuk Kim
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 tools/f2fs_io/f2fs_io.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
index 22f9968a35e9..d07e6c6b1bfe 100644
--- a/tools/f2fs_io/f2fs_io.c
+++ b/tools/f2fs_io/f2fs_io.c
@@ -101,6 +101,10 @@ static void *aligned_xalloc(size_t alignment, size_t size)
 
 	if (!p)
 		die("Memory alloc failed (requested %zu bytes)", size);
+
+	if (madvise(p, size, MADV_HUGEPAGE))
+		die("Madvise failed (requested %zu bytes)", size);
+
 	return p;
 }
 
-- 
2.51.0.618.g983fd99d29-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related	[flat|nested] 10+ messages in thread* Re: [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency
  2025-09-30  2:37 [f2fs-dev] [PATCH 1/5] f2fs_io: measure a fsync latency Jaegeuk Kim via Linux-f2fs-devel
                   ` (3 preceding siblings ...)
  2025-09-30  2:37 ` [f2fs-dev] [PATCH 5/5] f2fs_io: let's try to get contigous memory if possible Jaegeuk Kim via Linux-f2fs-devel
@ 2025-10-09  2:30 ` Chao Yu via Linux-f2fs-devel
  4 siblings, 0 replies; 10+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2025-10-09  2:30 UTC (permalink / raw)
  To: Jaegeuk Kim, linux-f2fs-devel
On 9/30/2025 10:37 AM, Jaegeuk Kim via Linux-f2fs-devel wrote:
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply	[flat|nested] 10+ messages in thread