From: Chao Yu <yuchao0@huawei.com>
To: kbuild test robot <lkp@intel.com>, Chao Yu <chao@kernel.org>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
kbuild-all@01.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [RFC PATCH f2fs] f2fs: release_discard_addr() can be static
Date: Fri, 27 Apr 2018 10:38:39 +0800 [thread overview]
Message-ID: <ceab8f88-be4b-a69e-c121-be5b4036d2ee@huawei.com> (raw)
In-Reply-To: <20180426195731.GA71397@xian>
Hi Fengguang, thanks for the fix.
To Jaegeuk, could you please merge it to original patch?
Thanks,
On 2018/4/27 3:57, kbuild test robot wrote:
>
> Fixes: 6f89409e87ce ("f2fs: introduce release_discard_addr() for cleanup")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 8652cfd..a0fce5e 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1598,7 +1598,7 @@ static bool add_discard_addrs(struct f2fs_sb_info *sbi, struct cp_control *cpc,
> return false;
> }
>
> -void release_discard_addr(struct discard_entry *entry)
> +static void release_discard_addr(struct discard_entry *entry)
> {
> list_del(&entry->list);
> kmem_cache_free(discard_entry_slab, entry);
>
> .
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
prev parent reply other threads:[~2018-04-27 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 19:57 [f2fs:dev-test 40/41] fs/f2fs/segment.c:1601:6: sparse: symbol 'release_discard_addr' was not declared. Should it be static? kbuild test robot
2018-04-26 19:57 ` [RFC PATCH f2fs] f2fs: release_discard_addr() can be static kbuild test robot
2018-04-27 2:38 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceab8f88-be4b-a69e-c121-be5b4036d2ee@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).