From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E54ECA0FF0 for ; Sat, 30 Aug 2025 01:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PmFDLYoX4G/8wfICwBMB71wPtTLhtX3N3NujcPHw6VU=; b=Glk+dtlH67h8fewAftTunSBvNP 0MOPG46bLdelSwoVRSbpMrZ3gVqczSFD7jM0w+4+s52xo7IlBKMR3rB0g2qAfXTTVPjPdmQWEe8zg LmZ4vFCGJSDoC4r1k5P9hfILH883dn4uUrnpQh6uFVtFRAApEZDU43l+XbOd1nXCqjMk=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1usA8V-0001vH-A3; Sat, 30 Aug 2025 01:12:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1usA8T-0001v1-H2 for linux-f2fs-devel@lists.sourceforge.net; Sat, 30 Aug 2025 01:12:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yv+CwrfdSMZJXaIsq9BVCMmUDkn/YqqhB5NOlEPidwY=; b=CWDPJCqr2A7z0mvRaCLvQPzDve 9dAFQwEp+yHWp7JnrmvdahKH9rrhtiCQNWDlkFan1zM+Jxl1n9n1Ip24ZapwBDZR7XdIMOFiwH8Md uUP3ZS/X03GgZSawcGeK/sm6CsvR4BBtykcBEXtiHyA4+3dLD8WFdbjX2XK2oePW2X4Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Yv+CwrfdSMZJXaIsq9BVCMmUDkn/YqqhB5NOlEPidwY=; b=MB7OV37HcujbjAFPEK0YkD0Yv5 bHfIN+evtpeiRjF2U7u7/yEYSS0k/1nKopci8TR71HmixKTfMUpcGeWNQfx9j3bl6QxuZY1MCTPkS LUvo07RQCWrXSiWwAAWr4A06B9TFcDobNHRS+aM2tNj+Jo/q7zg9mAoMoUMipXfUlqU4=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1usA8T-0003KQ-Tk for linux-f2fs-devel@lists.sourceforge.net; Sat, 30 Aug 2025 01:12:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8FB6B44F26 for ; Sat, 30 Aug 2025 01:12:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85877C4CEF0; Sat, 30 Aug 2025 01:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756516320; bh=tycl4yGmvMLiJ12nt0D6Iv196uuT9CH0W3/80EDmza8=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=ih+3OATp7z1kjkOLPNQ8RA8UjGhW3fAwlMok0LsgbTACMo0pqG/ila36CZYnoVj/y cu2Mmr2IG1ej0s0TLZ8qRwMAGkeKUSVRmNiqSgQEZoy+BIEsPlWqDYBlxiDN9e97Fz E/cFvtq4nVGWQ57InuVkjlKEkGV5QB0hHS4NSSQDjlOCBGFBoWtS69X+YNN9KjuoS9 tvdDP0SfRzn2e2JUM9Ngz0TS5iQV70GDZ1dlzOnoEcvPYPGKGzxux660ab29TaBDcO Zch4H2VoAzDy7b2lxKfKR4WYM73DlEcU8ZI+BbYyE0APmu8eOEufGoKW8oVmTOl1fV 3UH6KKn+TdofQ== Message-ID: Date: Sat, 30 Aug 2025 09:11:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jaegeuk Kim References: <20250827215222.1615844-1-jaegeuk@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1usA8T-0003KQ-Tk Subject: Re: [f2fs-dev] [PATCH] f2fs: allocate HOT_DATA for IPU writes X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 8/30/2025 4:47 AM, Jaegeuk Kim wrote: > On 08/29, Chao Yu wrote: >> On 8/28/2025 11:23 PM, Jaegeuk Kim wrote: >>> On 08/28, Chao Yu wrote: >>>> On 8/28/25 05:52, Jaegeuk Kim via Linux-f2fs-devel wrote: >>>>> Let's split IPU writes in hot data area to improve the GC efficiency. >>>> >>>> I didn't get it, IPU may be not friendly for migrating data along w/ write in >>>> hot area? >>> >>> This deals with IPU in the LFS mode. >> >> Okay, so, we missed to add f2fs_lfs_mode() condition, right? > > Why do we need that? As you mentioned above, this deals w/ IPU in the LFS mode. Am I missing something? Thanks, > >> >> Thanks, >> >>> >>>> >>>> Thanks, >>>> >>>>> >>>>> Signed-off-by: Jaegeuk Kim >>>>> --- >>>>> fs/f2fs/segment.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >>>>> index e0f6589c6a1c..bb79dad55ac9 100644 >>>>> --- a/fs/f2fs/segment.c >>>>> +++ b/fs/f2fs/segment.c >>>>> @@ -3688,7 +3688,8 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) >>>>> if (file_is_hot(inode) || >>>>> is_inode_flag_set(inode, FI_HOT_DATA) || >>>>> - f2fs_is_cow_file(inode)) >>>>> + f2fs_is_cow_file(inode) || >>>>> + is_inode_flag_set(inode, FI_NEED_IPU)) >>>>> return CURSEG_HOT_DATA; >>>>> return f2fs_rw_hint_to_seg_type(F2FS_I_SB(inode), >>>>> inode->i_write_hint); _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel