From: Chao Yu <yuchao0@huawei.com>
To: Ocean Chen <oceanchen@google.com>, <jaegeuk@kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: avoid out-of-range memory access
Date: Thu, 4 Jul 2019 15:22:13 +0800 [thread overview]
Message-ID: <d3a24db9-72a2-a162-025a-505909cf6ef2@huawei.com> (raw)
In-Reply-To: <20190703153320.203523-1-oceanchen@google.com>
On 2019/7/3 23:33, Ocean Chen wrote:
> blk_off might over 512 due to fs corrupt and should
> be checked before being used.
> Use ENTRIES_IN_SUM to protect invalid memory access.
>
> --
> v2:
> - fix typo
> v3:
> - check blk_off before being used
> --
> Signed-off-by: Ocean Chen <oceanchen@google.com>
> ---
> fs/f2fs/segment.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 8dee063c833f..c3eae3239345 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3401,6 +3401,9 @@ static int read_compacted_summaries(struct f2fs_sb_info *sbi)
> if (seg_i->alloc_type == SSR)
> blk_off = sbi->blocks_per_seg;
>
> + if (blk_off >= ENTRIES_IN_SUM)
> + return -EFAULT;
- scripts/checkpatch.pl will complain such format.
- miss to call f2fs_put_page(page, 1) before return.
Thanks,
> +
> for (j = 0; j < blk_off; j++) {
> struct f2fs_summary *s;
> s = (struct f2fs_summary *)(kaddr + offset);
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-07-04 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 15:33 [f2fs-dev] [PATCH v3] f2fs: avoid out-of-range memory access Ocean Chen via Linux-f2fs-devel
2019-07-04 7:22 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3a24db9-72a2-a162-025a-505909cf6ef2@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oceanchen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).