From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE4B7C0650E for ; Thu, 4 Jul 2019 07:22:29 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB440216E3; Thu, 4 Jul 2019 07:22:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="lV2AFe/i"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="kgAUsEFW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB440216E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hiw4R-00007s-NQ; Thu, 04 Jul 2019 07:22:19 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hiw4Q-00007i-W3 for linux-f2fs-devel@lists.sourceforge.net; Thu, 04 Jul 2019 07:22:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C/iMCdphMYDMw8UKJleCzGSlJIZJloqC1UptHrIEhWQ=; b=lV2AFe/i96TgDndKFrfCrYIzwA 3YHrw+6GL1+BM4ynQ+ZrzL5R7FLi8/euz9Q7IfORl1YZqaWsz2DHGrijHkcOfwnMuuwQvilIg0MJ2 kuvGeVcrkUojaF3WnmdXu3dW4zYiYg9TbWqvtjwiTngg4r8H1KYpx3uIvGVzy2HaIbWY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C/iMCdphMYDMw8UKJleCzGSlJIZJloqC1UptHrIEhWQ=; b=kgAUsEFWgPQ/zXeoqevBX9wPuN VwgYMFSuc6MjSUfADJhiD3UuTe1KMh4yR0cIaSCP6WFrd3Imp+a3XBta7qAbKgwv5drEOI8raywOU 6Tf9pibFGLCy0mhGYfmz+9cHQilUrree7qob1t2Eh/e9aaYJtTi/Itulcn29k/2CgyN0=; Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hiw4Y-007fPx-43 for linux-f2fs-devel@lists.sourceforge.net; Thu, 04 Jul 2019 07:22:28 +0000 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 47A2D71C5B86DF84055; Thu, 4 Jul 2019 15:22:18 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 4 Jul 2019 15:22:14 +0800 To: Ocean Chen , , , References: <20190703153320.203523-1-oceanchen@google.com> From: Chao Yu Message-ID: Date: Thu, 4 Jul 2019 15:22:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190703153320.203523-1-oceanchen@google.com> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1hiw4Y-007fPx-43 Subject: Re: [f2fs-dev] [PATCH v3] f2fs: avoid out-of-range memory access X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2019/7/3 23:33, Ocean Chen wrote: > blk_off might over 512 due to fs corrupt and should > be checked before being used. > Use ENTRIES_IN_SUM to protect invalid memory access. > > -- > v2: > - fix typo > v3: > - check blk_off before being used > -- > Signed-off-by: Ocean Chen > --- > fs/f2fs/segment.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 8dee063c833f..c3eae3239345 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -3401,6 +3401,9 @@ static int read_compacted_summaries(struct f2fs_sb_info *sbi) > if (seg_i->alloc_type == SSR) > blk_off = sbi->blocks_per_seg; > > + if (blk_off >= ENTRIES_IN_SUM) > + return -EFAULT; - scripts/checkpatch.pl will complain such format. - miss to call f2fs_put_page(page, 1) before return. Thanks, > + > for (j = 0; j < blk_off; j++) { > struct f2fs_summary *s; > s = (struct f2fs_summary *)(kaddr + offset); > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel