From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B7AC433DB for ; Thu, 21 Jan 2021 10:30:59 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8641204EF; Thu, 21 Jan 2021 10:30:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8641204EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1l2XEv-0008Ri-5u; Thu, 21 Jan 2021 10:30:57 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2XEn-0008QG-Be for linux-f2fs-devel@lists.sourceforge.net; Thu, 21 Jan 2021 10:30:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NRu+SVPL7A7J3Y7+NlEcLLabf9TPW7Fo8zkUPByPb/8=; b=HAJfQfyIAgUJInaOJbD6SL72kF zsOpG/ahv5RN/JOulUL/16aTpXZmiJc7O32NHI4ZETdPdtJpkh8fiIqdI4Cmb7Mq3kCQg1bQg8gwS KvGwWNEEIGkIpf7BV5ZNuKwsAGNXWHOOpCjutMx86BGDu7mZ2awJ0F1CzccuW1eY5Qvs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NRu+SVPL7A7J3Y7+NlEcLLabf9TPW7Fo8zkUPByPb/8=; b=hVC2Nd+tlCVw3KaRi2z/v563+t I14x1d7JGu1KRe0K5ezp4XjdrRx9Jt+hl7/eY0vCucT6Xte4DPeTaoakAv6Ki9v01jFytyYfhaX0B wwvvaGCJHvfkUNYc8UdxeJseMIFqNrf4w1wNJI2BMarZqlU5meqGvbz3JNencjj8tuzg=; Received: from szxga05-in.huawei.com ([45.249.212.191]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1l2XEc-002KFs-Qc for linux-f2fs-devel@lists.sourceforge.net; Thu, 21 Jan 2021 10:30:49 +0000 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DLzC02YL9zMNH7; Thu, 21 Jan 2021 18:29:00 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.208) with Microsoft SMTP Server (TLS) id 14.3.498.0; Thu, 21 Jan 2021 18:30:23 +0800 To: Daeho Jeong , , , References: <20210114062302.3809664-1-daeho43@gmail.com> <20210114062302.3809664-2-daeho43@gmail.com> From: Chao Yu Message-ID: Date: Thu, 21 Jan 2021 18:30:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210114062302.3809664-2-daeho43@gmail.com> Content-Language: en-US X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected X-Headers-End: 1l2XEc-002KFs-Qc Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: add ckpt_thread_ioprio sysfs node X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daeho Jeong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/1/14 14:23, Daeho Jeong wrote: > From: Daeho Jeong > > Added "ckpt_thread_ioprio" sysfs node to give a way to change checkpoint > merge daemon's io priority. Its default value is "be,3", which means > "BE" I/O class and I/O priority "3". We can select the class between "rt" > and "be", and set the I/O priority within valid range of it. > "," delimiter is necessary in between I/O class and priority number. > > Signed-off-by: Daeho Jeong > --- > v2: > - adapt to inlining ckpt_req_control of f2fs_sb_info > --- > Documentation/ABI/testing/sysfs-fs-f2fs | 8 ++++ > fs/f2fs/checkpoint.c | 2 +- > fs/f2fs/f2fs.h | 1 + > fs/f2fs/sysfs.c | 51 +++++++++++++++++++++++++ > 4 files changed, 61 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > index 3dfee94e0618..0c48b2e7dfd4 100644 > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > @@ -377,3 +377,11 @@ Description: This gives a control to limit the bio size in f2fs. > Default is zero, which will follow underlying block layer limit, > whereas, if it has a certain bytes value, f2fs won't submit a > bio larger than that size. > +What: /sys/fs/f2fs//ckpt_thread_ioprio > +Date: January 2021 > +Contact: "Daeho Jeong" > +Description: Give a way to change checkpoint merge daemon's io priority. > + Its default value is "be,3", which means "BE" I/O class and > + I/O priority "3". We can select the class between "rt" and "be", > + and set the I/O priority within valid range of it. "," delimiter > + is necessary in between I/O class and priority number. > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index e0668cec3b80..62bd6f449bb7 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1840,7 +1840,7 @@ int f2fs_start_ckpt_thread(struct f2fs_sb_info *sbi) > if (IS_ERR(cprc->f2fs_issue_ckpt)) > return PTR_ERR(cprc->f2fs_issue_ckpt); > > - set_task_ioprio(cprc->f2fs_issue_ckpt, DEFAULT_CHECKPOINT_IOPRIO); > + set_task_ioprio(cprc->f2fs_issue_ckpt, cprc->ckpt_thread_ioprio); Where do we set default value of cprc->ckpt_thread_ioprio? I guess it should be f2fs_init_ckpt_req_control()? Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel