Re: [PATCH] f2fs: check total CP pack block count correctly

[Chao Yu <yuchao0@huawei.com>]

On 2018/8/1 15:36, Sheng Yong wrote:
> 
> 
> On 2018/8/1 14:56, Chao Yu wrote:
>> Hi Sheng,
>>
>> On 2018/8/1 11:46, Sheng Yong wrote:
>>> Fixes: 652d19558a347 ('f2fs: fix to do sanity check with block address in main area')
>>> Reported-by: Zhang Xiaobo <tony.zhangxiaobo@huawei.com>
>>> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
>>
>> That's my bad, and thanks for the fix.
>>
>> Do you mind merge this into buggy patch, since the patch has not been upstreamed
>> yet.
> 
> No, of course not :)
> 
> Thanks,
> 
>>
>> Thanks,
>>
>>> ---
>>>   fs/f2fs/checkpoint.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>>> index 3587aa53dc90..c32ee10a1384 100644
>>> --- a/fs/f2fs/checkpoint.c
>>> +++ b/fs/f2fs/checkpoint.c
>>> @@ -809,7 +809,7 @@ static struct page *validate_checkpoint(struct f2fs_sb_info *sbi,
>>>   		goto invalid_cp1;
>>>   
>>>   	if (le32_to_cpu(cp_block->cp_pack_total_block_count) >
>>> -					sbi->log_blocks_per_seg) {
>>> +					sbi->blocks_per_seg - 1) {

actually, cp_pack_total_block_count can be sbi->blocks_per_seg?

Thanks,

>>>   		f2fs_msg(sbi->sb, KERN_WARNING,
>>>   			"invalid cp_pack_total_block_count:%u",
>>>   			le32_to_cpu(cp_block->cp_pack_total_block_count));
>>>
>>
>>
>> .
>>
> 
> 
> .
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot