From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A5EC4363D for ; Wed, 21 Oct 2020 01:23:25 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E3FA2098B; Wed, 21 Oct 2020 01:23:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="AyZSUBXy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="YL1FTXHe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ao4wEIjr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E3FA2098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kV2qV-00064u-9l; Wed, 21 Oct 2020 01:23:19 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kV2qU-00064n-29 for linux-f2fs-devel@lists.sourceforge.net; Wed, 21 Oct 2020 01:23:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-ID:References:In-Reply-To:Subject:Cc:To: From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qGge+OiVZHcS6eMn06MDb+HUQOh85jgQH0fDblnbuxQ=; b=AyZSUBXyhKjgOjJoAKFG6Jt7rq ngtFFEcSCd8XPZX2Q+UCF/EKy3NG4vLFHtvi3Z41b4EdNbn8CTk6jypl1WCff7r/SMLtDHx+dNG4/ J97EijjhfXKNEusDSLbMsP4Bt3YqXG7GdKIRtNy2HsNO9JSYGpayPSlndFUOACVzo57I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qGge+OiVZHcS6eMn06MDb+HUQOh85jgQH0fDblnbuxQ=; b=YL1FTXHeqSO+Hnnh15ePbOSr4y 7AhAUhcLeq0VbFW68n9tXzhDdEs1iJBtz4qszom9XBySzI0Zfu0SLuD1sGxN5pY5uXqktC1noHg+g qGY+nqFxBnUlLc4Nbowhu7GNaKBm3uo6nX+n8tcX6Y0jeiI9tkTePgNxgqB8bAxANz9s=; Received: from m42-4.mailgun.net ([69.72.42.4]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1kV2qD-000RuL-E8 for linux-f2fs-devel@lists.sourceforge.net; Wed, 21 Oct 2020 01:23:17 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603243381; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=qGge+OiVZHcS6eMn06MDb+HUQOh85jgQH0fDblnbuxQ=; b=ao4wEIjrSuYsaiuXBoDvpBJZIXi1DdCw0vGqxZQEISyDpLVA3n+mJlFL6r2zzVAO/R8l6b2Z tyTpTywPwWxlA2JPQfKAE4VhuXGSTNslymoPFQ198nr4maWyXPKT6zkMkqzsnQ2DVWBK0Yr7 t8Q4jCl2a2/N/r3DkAD60ri1Wxs= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI2M2Y4ZiIsICJsaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldCIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5f8f877e52f4fccef0e381a9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 21 Oct 2020 00:57:34 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 91A10C433FE; Wed, 21 Oct 2020 00:57:33 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9950AC433C9; Wed, 21 Oct 2020 00:57:32 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 21 Oct 2020 08:57:32 +0800 From: Can Guo To: Jaegeuk Kim In-Reply-To: <20201020195258.2005605-4-jaegeuk@kernel.org> References: <20201020195258.2005605-1-jaegeuk@kernel.org> <20201020195258.2005605-4-jaegeuk@kernel.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-Headers-End: 1kV2qD-000RuL-E8 Subject: Re: [f2fs-dev] [PATCH v2 3/5] scsi: ufs: use WQ_HIGHPRI for gating work X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Avri Altman , Alim Akhtar , kernel-team@android.com, Jaegeuk Kim Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020-10-21 03:52, Jaegeuk Kim wrote: > From: Jaegeuk Kim > > Must have WQ_MEM_RECLAIM > ``WQ_MEM_RECLAIM`` > All wq which might be used in the memory reclaim paths **MUST** > have this flag set. The wq is guaranteed to have at least one > execution context regardless of memory pressure. > You misunderstood my point. I meant you need to give more info about why we are adding WQ_HIGHPRI flag but not why WQ_MEM_RECLAIM must be there. Thanks, Can Guo. > Cc: Alim Akhtar > Cc: Avri Altman > Cc: Can Guo > Signed-off-by: Jaegeuk Kim > --- > drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index feb10ebf7a35..0858c0b55eac 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -1867,7 +1867,7 @@ static void ufshcd_init_clk_gating(struct ufs_hba > *hba) > snprintf(wq_name, ARRAY_SIZE(wq_name), "ufs_clk_gating_%d", > hba->host->host_no); > hba->clk_gating.clk_gating_workq = alloc_ordered_workqueue(wq_name, > - WQ_MEM_RECLAIM); > + WQ_MEM_RECLAIM | WQ_HIGHPRI); > > hba->clk_gating.is_enabled = true; _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel