From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1721C433F5 for ; Fri, 15 Apr 2022 05:24:19 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nfERN-0004M2-C5; Fri, 15 Apr 2022 05:24:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nfERL-0004Lw-Lg for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Apr 2022 05:24:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vKRwgfC4ED3wBU2n2i2ZES29ZkioKhUCaYEzFIzNAoM=; b=fcv6hhypEqrGYXKW0fcztP35ZR 81xGICF5l2gd6HalvSvp/Mlcnudj5l1In0gOK85iVkGzOAm5xbCJ9Jnnuo3Bf5YBIku3r3nDRXlZx 0XVV5OOf6ov9CoAEvwx/cI2F//RnCYHZVaw3mLN6/fmvxngTfTvDD6eZXDAoUqWUXmvk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vKRwgfC4ED3wBU2n2i2ZES29ZkioKhUCaYEzFIzNAoM=; b=ZVALLBoSKrQ8gxxlvlI9REs4xR 2wr0N2PSZ2cDhGMCQIW0Eu5nte5Oc8UVmycdnxm6J4jS+qw9RezlxTN4IC0qhI3sHD5HiNPl2NUq+ qoygseeORPkvAACiWl0VLywTuSugma2zLZe0hP4nUdXqEU6ZGyZdb+hRsnE3kYToltWI=; Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nfERL-0003QP-6r for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Apr 2022 05:24:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650000254; x=1681536254; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6js5zQuBI=; b=SjLutd0K7JvZm9ejuCThoO69HBa1+l0KMb7WWoa1JNgiw3dHXXCf0ZP+ CNCMie+/ES/tdIbFc5r+/N1GlIaAB/t1nMquCfKsm43JMF4QMkyTT14Gn mBVF4zUMoU+KwmJqPWi/d3xGbGdRbbXqoorOVfACaHhLwXpP/TkoF06/x AV/ygyLCxSq7DBVH9/Xg+yqXXVDsSYvpgkv2e8IWRBDu3enihm+JEPoZS gBH4Z5PieHc80i44WW0fRS0pavRBGs4XCYjerwQ+0JigH+3F1vx0bntKO ejReL5e5CJluQtwBTKuPyJAKF4XwdJXiD0D8l2gTUhtE+kOqO/7gxyMdq w==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="196832496" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:08:27 +0800 IronPort-SDR: FLYPvl0cPWBpJbc3CmzMBttZUkeFHr9jMiIbgELwW5FsGBgt+Wti8QeLnalx4mfwvAGCGg0/5G ZPYzOTrVlBJtwj5heYLhnFJWB9u41UJ7+9iLE0jLCiqhOqHBMqCFbvH3jbAHfo8SDQfLd514E7 h8flJTH8Aa/fVKoYlFuIeDmenD5jpl6kPa5HOk9G55HeiVlycwKS4NB+Q4v1mlIBdGwK7Iu1WK vbPGHw/vjcFOMMvLhwInH3xi3mo3IeHKS0LABxuKniPLQx/HVUVbGCKP8APi5eI1gPRQXv+W60 F2tmW/61TYylqqghlx9+OXw7 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:39:39 -0700 IronPort-SDR: I6S7h6CVU4ioHGTExGSjxajV9QAoB14VsxM0FNSS6wmqrpXtlY3RAV7TK89oz6dS6FWf7ZKNHJ n45YRJWmWVNSyVz9m359BoyWroRPyXM/FVWbtHvSTZd5D48EPrr2DUlgHecq4pN1YUNEv414iU Jko30+7zpIMGgptwTHJxv9V7nTm/8agyexWov3CUL0EQ9vlEKFPatlhyHWxEOnhp+ET8YSYLv3 P6JHWe66MOqM0hZqVCB9HwSkx4GbWGPMBp4ERgXCdGBsk3jx2O/wfQJvPzI2sO79oZwhEk47tC mA0= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:08:28 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kfkqv2lspz1SVnx for ; Thu, 14 Apr 2022 22:08:27 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999306; x=1652591307; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6 js5zQuBI=; b=ImgmXK0ljefxmjcwwGCZe/P1ZAiYRfxiStEm0q2wFeKQMvkTL85 MoEiv1WWngR6yiDdywhy6m6c7CHetStsP2KPL7aGmRBSEDoQ0BBkWf7uSl7GctxX seFLiVHTqharLpAbcplk3yzDBSQpNNHnyTWqCGnT6SDEQPGGz4njOldB2JpZjV0c Fn1jBi13ZsAeHMQyLgImvLHIeNwH3xSreGo+kohOYlio/FQU9mPmWWTRsJd3G6Vg s7uGQ1kCv0yoS1gOWClHM7ArPs0jj6m4kJVcJWYcgsITqalXpkzGP3XvQ+R3owbL r+qmM2ogk4tvzMNidepDhru5fT38QuGd/Yg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NAIXMllB-sQM for ; Thu, 14 Apr 2022 22:08:26 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kfkqn6sCZz1Rvlx; Thu, 14 Apr 2022 22:08:21 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 14:08:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Christoph Hellwig , Jens Axboe References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> Organization: Western Digital Research In-Reply-To: <20220415045258.199825-28-hch@lst.de> X-Headers-End: 1nfERL-0003QP-6r Subject: Re: [f2fs-dev] [PATCH 27/27] direct-io: remove random prefetches X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Damien Le Moal via Linux-f2fs-devel Reply-To: Damien Le Moal Cc: jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, cluster-devel@redhat.com, xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org, linux-um@lists.infradead.org, nbd@other.debian.org, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel