[f2fs-dev] [PATCH 1/2] f2fs-tools: delete only if the libf2fs_format.so* exists

[f2fs-dev] [PATCH 1/2] f2fs-tools: delete only if the libf2fs_format.so* exists

[Jianan Huang via Linux-f2fs-devel]

Otherwise we will get the following error when executing make uninstall:

make  uninstall-hook
make[2]: Entering directory '/home/huangjianan/code/f2fs-tools/mkfs'
rm /usr/local/lib/libf2fs_format.so*
rm: cannot remove '/usr/local/lib/libf2fs_format.so*': No such file or directory
make[2]: *** [Makefile:827: uninstall-hook] Error 1
make[2]: Leaving directory '/home/huangjianan/code/f2fs-tools/mkfs'
make[1]: *** [Makefile:790: uninstall-am] Error 2
make[1]: Leaving directory '/home/huangjianan/code/f2fs-tools/mkfs'
make: *** [Makefile:418: uninstall-recursive] Error 1

Fixes: b067004c92dc ("add configure option --with-root-libdir")
Signed-off-by: Jianan Huang <huangjianan@xiaomi.com>
---
 mkfs/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
index bfffd88..fb7bce8 100644
--- a/mkfs/Makefile.am
+++ b/mkfs/Makefile.am
@@ -27,4 +27,6 @@ install-exec-hook:
 	fi
 
 uninstall-hook:
-	rm $(DESTDIR)$(root_libdir)/libf2fs_format.so*
+	if test -f "$(DESTDIR)$(root_libdir)/libf2fs_format.so*"; then \
+		rm $(DESTDIR)$(root_libdir)/libf2fs_format.so*; \
+	fi
\ No newline at end of file
-- 
2.43.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH 2/2] f2fs-tools: clean up dump.f2fs etc. when uninstall

[Jianan Huang via Linux-f2fs-devel]

Otherwise, some lonely soft links will be left in /usr/local/bin.

Signed-off-by: Jianan Huang <huangjianan@xiaomi.com>
---
 fsck/Makefile.am | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fsck/Makefile.am b/fsck/Makefile.am
index ea3b26a..f0d7f87 100644
--- a/fsck/Makefile.am
+++ b/fsck/Makefile.am
@@ -21,3 +21,11 @@ install-data-hook:
 	ln -sf fsck.f2fs $(DESTDIR)/$(sbindir)/sload.f2fs
 	ln -sf fsck.f2fs $(DESTDIR)/$(sbindir)/f2fslabel
 	ln -sf fsck.f2fs $(DESTDIR)/$(sbindir)/inject.f2fs
+
+uninstall-hook:
+	-rm -f $(DESTDIR)/$(sbindir)/dump.f2fs
+	-rm -f $(DESTDIR)/$(sbindir)/defrag.f2fs
+	-rm -f $(DESTDIR)/$(sbindir)/resize.f2fs
+	-rm -f $(DESTDIR)/$(sbindir)/sload.f2fs
+	-rm -f $(DESTDIR)/$(sbindir)/f2fslabel
+	-rm -f $(DESTDIR)/$(sbindir)/inject.f2fs
-- 
2.43.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 1/2] f2fs-tools: delete only if the libf2fs_format.so* exists

[Chao Yu via Linux-f2fs-devel]

On 5/8/25 20:42, Jianan Huang wrote:
> Otherwise we will get the following error when executing make uninstall:
> 
> make  uninstall-hook
> make[2]: Entering directory '/home/huangjianan/code/f2fs-tools/mkfs'
> rm /usr/local/lib/libf2fs_format.so*
> rm: cannot remove '/usr/local/lib/libf2fs_format.so*': No such file or directory
> make[2]: *** [Makefile:827: uninstall-hook] Error 1
> make[2]: Leaving directory '/home/huangjianan/code/f2fs-tools/mkfs'
> make[1]: *** [Makefile:790: uninstall-am] Error 2
> make[1]: Leaving directory '/home/huangjianan/code/f2fs-tools/mkfs'
> make: *** [Makefile:418: uninstall-recursive] Error 1
> 
> Fixes: b067004c92dc ("add configure option --with-root-libdir")
> Signed-off-by: Jianan Huang <huangjianan@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 2/2] f2fs-tools: clean up dump.f2fs etc. when uninstall

[Chao Yu via Linux-f2fs-devel]

On 5/8/25 20:42, Jianan Huang wrote:
> Otherwise, some lonely soft links will be left in /usr/local/bin.
> 
> Signed-off-by: Jianan Huang <huangjianan@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel