Re: [PATCH v5] f2fs: introduce a method to make nat journal more fresh

[Chao Yu <chao@kernel.org>]

On 2018/4/14 8:48, Jaegeuk Kim wrote:
> I removed this patch in my test branch, since it simply gave a kernel panic.
> Please test before sending patches.

Sorry, I didn't find this bug in previous review.

Look at this patch again,

> +	/* journal hit case, try to locate set in journal */
> +	if (!remove_journal && head->entry_cnt <= NAT_JOURNAL_ENTRIES)

head pointer can be a random value before using.

To Yunlei, could you please fix this, and do the test (at least with xfstest)
before resending it.

Thanks,

> 
> repro
> 1. encrypt a dir
> 2. dd to create 10MB-sized file in the dir
> 
> On 04/12, Chao Yu wrote:
>> On 2018/4/10 15:11, Yunlei He wrote:
>>> This patch introduce a method to make nat journal more fresh:
>>> i.  sort set list using dirty entry number and cp version
>>>     average value.
>>> ii. if meet with cache hit, update average version valus with
>>>     current cp version.
>>>
>>> With this patch, newly modified nat set will flush to journal,
>>> and flush old nat set with same dirty entry number to nat area.
>>>
>>> Signed-off-by: Yunlei He <heyunlei@huawei.com>
>>
>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>>
>> Thanks,
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot