From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH v5] f2fs: introduce a method to make nat journal more fresh Date: Sat, 14 Apr 2018 09:22:35 +0800 Message-ID: References: <1523344306-16493-1-git-send-email-heyunlei@huawei.com> <527e85f8-e407-1897-9929-b9a8be53f557@huawei.com> <20180414004800.GA35840@jaegeuk-macbookpro.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1f79u0-0003BV-Pl for linux-f2fs-devel@lists.sourceforge.net; Sat, 14 Apr 2018 01:22:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1f79ty-00GWYO-2u for linux-f2fs-devel@lists.sourceforge.net; Sat, 14 Apr 2018 01:22:52 +0000 In-Reply-To: <20180414004800.GA35840@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim , Chao Yu Cc: zhangdianfang@huawei.com, linux-f2fs-devel@lists.sourceforge.net On 2018/4/14 8:48, Jaegeuk Kim wrote: > I removed this patch in my test branch, since it simply gave a kernel panic. > Please test before sending patches. Sorry, I didn't find this bug in previous review. Look at this patch again, > + /* journal hit case, try to locate set in journal */ > + if (!remove_journal && head->entry_cnt <= NAT_JOURNAL_ENTRIES) head pointer can be a random value before using. To Yunlei, could you please fix this, and do the test (at least with xfstest) before resending it. Thanks, > > repro > 1. encrypt a dir > 2. dd to create 10MB-sized file in the dir > > On 04/12, Chao Yu wrote: >> On 2018/4/10 15:11, Yunlei He wrote: >>> This patch introduce a method to make nat journal more fresh: >>> i. sort set list using dirty entry number and cp version >>> average value. >>> ii. if meet with cache hit, update average version valus with >>> current cp version. >>> >>> With this patch, newly modified nat set will flush to journal, >>> and flush old nat set with same dirty entry number to nat area. >>> >>> Signed-off-by: Yunlei He >> >> Reviewed-by: Chao Yu >> >> Thanks, > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot