From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: "linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] f2fs_symlink bug
Date: Wed, 21 Aug 2019 16:36:25 +0800 [thread overview]
Message-ID: <dfd847fe-0c6d-f2a1-db50-d637a685d13b@huawei.com> (raw)
In-Reply-To: <3bc8584e-651c-9578-c25a-40c60b5cfbdb@huawei.com>
Ping,
On 2019/8/12 20:01, Chao Yu wrote:
> Hi Jaegeuk,
>
> In por_fsstress testcase, fsck reports below inconsistent status, I found one
> path can cause this case.
>
> [FIX] (fsck_chk_inode_blk:1002) --> Symlink: recover 0x1425 with i_size=4096
> [ASSERT] (fsck_chk_inode_blk:1030) --> ino: 0x1425 chksum:0x6983d47, but
> calculated one is: 0xdb284b35
> [FIX] (fsck_chk_inode_blk:1036) --> ino: 0x1425 recover, i_inode_checksum=
> 0x6983d47 -> 0xdb284b35
>
> - f2fs_symlink
> - page_symlink failed -> f2fs_write_failed() will truncate size to zero
> - f2fs_unlink failed -> symlink inode w/o data will remain in fs
>
> Not sure, but one choice of fix is to treat symlink as fs meta like we did for
> directory, so that checkpoint can take care of all data/node of symlink, any
> thoughts?
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-08-21 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 12:01 [f2fs-dev] f2fs_symlink bug Chao Yu
2019-08-21 8:36 ` Chao Yu [this message]
2019-08-22 19:49 ` Jaegeuk Kim
2019-08-23 1:39 ` Chao Yu
2019-08-23 15:04 ` Jaegeuk Kim
2019-08-23 15:48 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd847fe-0c6d-f2a1-db50-d637a685d13b@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).