From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A4FC3F2D2 for ; Fri, 6 Mar 2020 01:19:57 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5433020726; Fri, 6 Mar 2020 01:19:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="Ma7sRI/W"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="DQosXgt6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5433020726 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jA1ed-0005nZ-VG; Fri, 06 Mar 2020 01:19:55 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jA1ec-0005nS-VS for linux-f2fs-devel@lists.sourceforge.net; Fri, 06 Mar 2020 01:19:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=I13llcu/Wrs6zMSmAU8dxK9xRlce4dAdS7DYx5+VY1A=; b=Ma7sRI/W4geWypDUfPs8Jsuu13 EtsQ55J1gJA5K2t+XAp+IbcglU5ZuvYzYu+fAyYeHrPteK+oOqCEaFsWC0qiz8imC8AEEi9Ks3lY4 b3tni8L83ZFIuqvMVYegJ+Yj2cHSrGCXEcrKGaUyctCKy6Wm8rAFqez0nZhVTaz19D0A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=I13llcu/Wrs6zMSmAU8dxK9xRlce4dAdS7DYx5+VY1A=; b=DQosXgt6Cnesu5gH9Stf1c3+l1 5aIH0PsMenmeWglS/SVmnuzVokDQoHg2eZKpQzYlkdrTNxUYKjX3Kyb9nT7E/mcDKkG+B+vRXevx2 FUXeWzK98c9A5BbmvQurbnrTZWL8bvSynPdLWBcXjvkuB78arB/2vmfKgPbsQ6Ofdq7Q=; Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jA1ea-009jyV-77 for linux-f2fs-devel@lists.sourceforge.net; Fri, 06 Mar 2020 01:19:54 +0000 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 77563EC8DC063C1F3480; Fri, 6 Mar 2020 09:19:43 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 6 Mar 2020 09:19:41 +0800 To: Sahitya Tummala , Jaegeuk Kim , References: <1583245766-3351-1-git-send-email-stummala@codeaurora.org> <1583245766-3351-2-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Fri, 6 Mar 2020 09:19:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1583245766-3351-2-git-send-email-stummala@codeaurora.org> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jA1ea-009jyV-77 Subject: Re: [f2fs-dev] [PATCH V2 2/2] f2fs: Add a new CP flag to help fsck fix resize SPO issues X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/3/3 22:29, Sahitya Tummala wrote: > Add and set a new CP flag CP_RESIZEFS_FLAG during > online resize FS to help fsck fix the metadata mismatch > that may happen due to SPO during resize, where SB > got updated but CP data couldn't be written yet. > > fsck errors - > Info: CKPT version = 6ed7bccb > Wrong user_block_count(2233856) > [f2fs_do_mount:3365] Checkpoint is polluted I'm not against this patch, however without this change, could fsck have any chance to repair old image? > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel