From: Joe Perches <joe@perches.com>
To: Chao Yu <yuchao0@huawei.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce f2fs_<level> macros to wrap f2fs_printk()
Date: Wed, 19 Jun 2019 21:58:18 -0700 [thread overview]
Message-ID: <e1f85a06454a88ee72f03f60cc55a30b60676df4.camel@perches.com> (raw)
In-Reply-To: <96d46153-8bf8-b152-2ae3-3ddeac0ba914@huawei.com>
On Thu, 2019-06-20 at 10:08 +0800, Chao Yu wrote:
> On 2019/6/20 4:52, Jaegeuk Kim wrote:
> > On 06/19, Joe Perches wrote:
> > > On Wed, 2019-06-19 at 11:01 -0700, Jaegeuk Kim wrote:
> > > > On 06/18, Chao Yu wrote:
> > > > > From: Joe Perches <joe@perches.com>
> > > > >
> > > > > - Add and use f2fs_<level> macros
> > > > > - Convert f2fs_msg to f2fs_printk
> > > > > - Remove level from f2fs_printk and embed the level in the format
> > > > > - Coalesce formats and align multi-line arguments
> > > > > - Remove unnecessary duplicate extern f2fs_msg f2fs.h
> > > >
> > > > Can we just use sbi for f2fs_<level>?
> > >
> > > Not really. see below:
> >
> > Since sbi = F2FS_SB(sb), I don't see any problem.
> >
> > > > And, could you please change missing
> > > > f2fs_msg() in the latest dev?
> > >
> > > Anyone is welcome to refresh the patch as necessary
> > > or appropriate.
> >
> > Could you please take a look at this?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=697743b1c1025483c97c740cd8834711be4294eb
>
> Looks good to me.
Me too. cheers, Joe
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2019-06-20 4:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 9:48 [f2fs-dev] [PATCH] f2fs: introduce f2fs_<level> macros to wrap f2fs_printk() Chao Yu
2019-06-19 18:01 ` Jaegeuk Kim
2019-06-19 18:19 ` Joe Perches
2019-06-19 20:52 ` Jaegeuk Kim
2019-06-20 2:08 ` Chao Yu
2019-06-20 4:58 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1f85a06454a88ee72f03f60cc55a30b60676df4.camel@perches.com \
--to=joe@perches.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).