linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Ju Hyung Park <qkrwngud825@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v3 2/2] f2fs-tools: relocate chksum_offset for large_nat_bitmap feature
Date: Sun, 19 May 2019 23:09:13 +0800	[thread overview]
Message-ID: <e3303318-758e-b263-f6ed-d55e98bdea78@kernel.org> (raw)
In-Reply-To: <CAD14+f1xgYKAnzqLb-ZpzbeskZegGHXbrJ+vEHZe19_Jp3pBTQ@mail.gmail.com>

Hi Ju Hyung,

On 2019-5-19 17:19, Ju Hyung Park wrote:
> Hi Chao,
> 
> On Sun, May 19, 2019 at 2:09 PM Chao Yu <chao@kernel.org> wrote:
>> I've found one bug when repairing cp_payload blocks, could you try it?
>>
>> [PATCH] fsck.f2fs: fix to repair cp_loads blocks at correct position
> 
> http://arter97.com/f2fs/v3__cp
> 
> After the patch, 2nd, 3rd and the 4th run all returns the same output.
> I think now fsck only needs to run once :)

Thanks for quick test. :)

> 
> Final question though, is it expected that the first run to print 62MB
> worth of logs?

I think last bug which above patch tries to fix really crashes sit version
bitmap area.. result in wrong sit block use and showing so many error messages
in fsck, that should only happen when the image is badly corrupted, I think it
is worth to show enough information which can be used for better troubleshoot later.

Thanks,

> 
> Thanks.
> 

  reply	other threads:[~2019-05-19 15:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  9:33 [PATCH v3 1/2] f2fs-tools: allow unfixed f2fs_checkpoint.checksum_offset Chao Yu
2019-05-14  9:33 ` [PATCH v3 2/2] f2fs-tools: relocate chksum_offset for large_nat_bitmap feature Chao Yu
     [not found]   ` <CAD14+f2ckNUv9n-Zb9UL_ojX8=24tYBhT-SsrcpVNogqee2tkA@mail.gmail.com>
2019-05-14  9:43     ` Chao Yu
     [not found]       ` <CAD14+f3NHosrL=5UOBSMbFxQ91x-AuWOj_w=JYkJSnmfDgTkvA@mail.gmail.com>
2019-05-15  4:50         ` Ju Hyung Park
2019-05-15  9:23           ` Chao Yu
2019-05-18 20:09             ` Ju Hyung Park
2019-05-19  5:09               ` Chao Yu
2019-05-19  9:19                 ` Ju Hyung Park
2019-05-19 15:09                   ` Chao Yu [this message]
2019-06-03 15:23                     ` Ju Hyung Park
2019-06-03 20:27                       ` Jaegeuk Kim
2019-06-04  1:48                         ` Chao Yu
2019-06-27  9:12                           ` [f2fs-dev] " Ju Hyung Park
2019-06-27 10:20                             ` Chao Yu
2019-07-01  6:23                               ` Ju Hyung Park
2019-07-01  9:43                                 ` Chao Yu
2019-07-05 18:31                                   ` Jaegeuk Kim
2019-07-06  1:39                                     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3303318-758e-b263-f6ed-d55e98bdea78@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=qkrwngud825@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).