From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [PATCH v3 2/2] f2fs-tools: relocate chksum_offset for large_nat_bitmap feature Date: Sun, 19 May 2019 23:09:13 +0800 Message-ID: References: <20190514093340.40217-1-yuchao0@huawei.com> <20190514093340.40217-2-yuchao0@huawei.com> <6bcbb5e8-55ad-49c1-bb77-f7f677ceb526@huawei.com> <7e1bfa07-5ee8-a276-fe6a-6d79bd9270c3@huawei.com> <0f89b0b6-5cc5-6618-72e5-8a2f81947161@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hSNRH-0006jY-3V for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 May 2019 15:09:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hSNRE-008is6-9v for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 May 2019 15:09:27 +0000 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Ju Hyung Park Cc: Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Hi Ju Hyung, On 2019-5-19 17:19, Ju Hyung Park wrote: > Hi Chao, > > On Sun, May 19, 2019 at 2:09 PM Chao Yu wrote: >> I've found one bug when repairing cp_payload blocks, could you try it? >> >> [PATCH] fsck.f2fs: fix to repair cp_loads blocks at correct position > > http://arter97.com/f2fs/v3__cp > > After the patch, 2nd, 3rd and the 4th run all returns the same output. > I think now fsck only needs to run once :) Thanks for quick test. :) > > Final question though, is it expected that the first run to print 62MB > worth of logs? I think last bug which above patch tries to fix really crashes sit version bitmap area.. result in wrong sit block use and showing so many error messages in fsck, that should only happen when the image is badly corrupted, I think it is worth to show enough information which can be used for better troubleshoot later. Thanks, > > Thanks. >