From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 954E3C4345F for ; Sun, 28 Apr 2024 03:17:55 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s0v33-0007KK-Go; Sun, 28 Apr 2024 03:17:53 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s0v31-0007KB-Tw for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Apr 2024 03:17:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IqRP7ge6tWlHIT3uS8hf73NpEdKtcHLWFvZPaVxJ4pA=; b=nBQkGHhNvy9t6nXUQw8iWbhalj xnc0L2doBttuIkLseLe2iB74V2ngGauA0yl+7AocfVGYNHwYWw8uyk1PhmS9v7qy2lNM+1hUspvVM gKk7PPfwT60Ldn0wo/m0IzhlQ9Q28NxX2nWoAHJIcVW/wH0yaPokO6NkGJNFAHkuE590=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IqRP7ge6tWlHIT3uS8hf73NpEdKtcHLWFvZPaVxJ4pA=; b=EUwQGctJV7AnkgD0gi4f5+3hpA 23jGPjLiFu/2xQgCzCdGJLPjFPGGpt3FTcEVvan9ou23KBISzTsi7BVHFjYpxbJqEo0W5rnGMb2fA qFfWcVQCSJyylkDXr9r70W+ZNAnbbSbPIzahnVRflr1kVIiTXfGi08oV/rToCg4dRmvQ=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1s0v31-0006tc-7W for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Apr 2024 03:17:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3684D60349; Sun, 28 Apr 2024 03:17:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B53A4C4AF17; Sun, 28 Apr 2024 03:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714274265; bh=Stf6RD+wk0dcrnB98wXmtvpPzh3y/7iTC6dGDf6CG6E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eSE1W0uggxKHMhGrafLiJ1MoFp6jqU0EtHhmTgaE7FD4rgDGhvXvwpgtHYv7X7tv9 IUyXlgs2qZyH77BpEWVg91SzUXwOMH+0G6jiV5pKwep68UypOG9Y6DaiiKLz6Mkczc kma9smBLp1ZgQZvjYGPIXrgitC0pyJTSmmtX+w8nYqWqXEF9r8q8iTzLjvTlhwNUAQ 3avnbxMudfJ/zwx0/ZETQql4MRxSBH0e9dBBPqGsHAXBLDeBw6UUwMm0qJOCmWdveF nIsER7Q+8JoeGWomOi6vvyBFi69Rk0dKnLglCYpQe70Ux/uu/E9KY2+EUcikN9uZuI semwXapexl8aA== Message-ID: Date: Sun, 28 Apr 2024 11:17:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Matthew Wilcox , Kairui Song References: <20240423170339.54131-1-ryncsn@gmail.com> <20240423170339.54131-4-ryncsn@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: X-Headers-End: 1s0v31-0006tc-7W Subject: Re: [f2fs-dev] [PATCH v2 3/8] f2fs: drop usage of page_index X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Roberts , Chris Li , Neil Brown , Minchan Kim , Hugh Dickins , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Yosry Ahmed , linux-mm@kvack.org, Barry Song , "Huang, Ying" , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , Andrew Morton , David Hildenbrand Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2024/4/24 6:58, Matthew Wilcox wrote: > On Wed, Apr 24, 2024 at 01:03:34AM +0800, Kairui Song wrote: >> @@ -4086,8 +4086,7 @@ void f2fs_clear_page_cache_dirty_tag(struct page *page) >> unsigned long flags; >> >> xa_lock_irqsave(&mapping->i_pages, flags); >> - __xa_clear_mark(&mapping->i_pages, page_index(page), >> - PAGECACHE_TAG_DIRTY); >> + __xa_clear_mark(&mapping->i_pages, page->index, PAGECACHE_TAG_DIRTY); >> xa_unlock_irqrestore(&mapping->i_pages, flags); >> } > > I just sent a patch which is going to conflict with this: > > https://lore.kernel.org/linux-mm/20240423225552.4113447-3-willy@infradead.org/ > > Chao Yu, Jaegeuk Kim; what are your plans for converting f2fs to use Hi Matthew, I've converted .read_folio and .readahead of f2fs to use folio w/ below patchset, and let me take a look how to support and enable large folio... https://lore.kernel.org/linux-f2fs-devel/20240422062417.2421616-1-chao@kernel.org/ Thanks, > folios? This is getting quite urgent. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel