From: Damien Le Moal via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-block@vger.kernel.org,
Paolo Valente <paolo.valente@linaro.org>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>
Subject: Re: [f2fs-dev] [PATCH v3 3/4] block: rename IOPRIO_BE_NR
Date: Sun, 8 Aug 2021 15:29:08 +0900 [thread overview]
Message-ID: <e98cdc46-a58e-2c20-b0ab-5a93c4bf66c0@opensource.wdc.com> (raw)
In-Reply-To: <5f2640c5-0712-b822-9ac7-3daa974c0c30@kernel.dk>
On 2021/08/08 1:16, Jens Axboe wrote:
> On 8/6/21 5:18 AM, Damien Le Moal wrote:
>> diff --git a/include/uapi/linux/ioprio.h b/include/uapi/linux/ioprio.h
>> index abc40965aa96..99d37d4807b8 100644
>> --- a/include/uapi/linux/ioprio.h
>> +++ b/include/uapi/linux/ioprio.h
>> @@ -31,9 +31,9 @@ enum {
>> };
>>
>> /*
>> - * 8 best effort priority levels are supported
>> + * The RT and BE priority classes both support up to 8 priority levels.
>> */
>> -#define IOPRIO_BE_NR 8
>> +#define IOPRIO_NR_LEVELS 8
>
> That might not be a good idea, if an application already uses
> IOPRIO_BE_NR...
Hmmm. include/uapi/linux/ioprio.h is being introduced with kernel 5.15. These
definition are not UAPI level right now.
What about something like this:
#define IOPRIO_NR_LEVELS 8
#define IOPRIO_BE_NR IOPRIO_NR_LEVELS
To keep IOPRIO_BE_NR ?
OR,
Keep IOPRIO_BE_NR as is in include/uapi/linux/ioprio.h and add
#define IOPRIO_NR_LEVELS IOPRIO_BE_NR
in include/linux/ioprio.h ?
Both would still allow doing some cleanup kernel side.
Or I can just drop this patch too.
--
Damien Le Moal
Western Digital Research
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-08-08 6:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 11:18 [f2fs-dev] [PATCH v3 0/4] IO priority fixes and improvements Damien Le Moal
2021-08-06 11:18 ` [f2fs-dev] [PATCH v3 1/4] block: bfq: fix bfq_set_next_ioprio_data() Damien Le Moal
2021-08-06 11:18 ` [f2fs-dev] [PATCH v3 2/4] block: fix ioprio interface Damien Le Moal
2021-08-07 16:18 ` Jens Axboe
2021-08-08 6:29 ` Damien Le Moal via Linux-f2fs-devel
2021-08-06 11:18 ` [f2fs-dev] [PATCH v3 3/4] block: rename IOPRIO_BE_NR Damien Le Moal
2021-08-06 11:38 ` Hannes Reinecke
2021-08-07 16:16 ` Jens Axboe
2021-08-08 6:29 ` Damien Le Moal via Linux-f2fs-devel [this message]
2021-08-09 7:45 ` Christoph Hellwig
2021-08-06 11:18 ` [f2fs-dev] [PATCH v3 4/4] block: fix default IO priority handling Damien Le Moal
2021-08-07 16:19 ` Jens Axboe
2021-08-08 6:31 ` Damien Le Moal via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98cdc46-a58e-2c20-b0ab-5a93c4bf66c0@opensource.wdc.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).