From: Chao Yu <chao@kernel.org>
To: Yunlei He <heyunlei@huawei.com>,
jaegeuk@kernel.org, yuchao0@huawei.com,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: remove unneed reada during build free nids
Date: Fri, 9 Feb 2018 21:36:36 +0800 [thread overview]
Message-ID: <eb931c4a-7d7b-22f8-0ef8-ddd2fa880781@kernel.org> (raw)
In-Reply-To: <1518148722-31212-1-git-send-email-heyunlei@huawei.com>
On 2018/2/9 11:58, Yunlei He wrote:
> This patch remove unneed reada during build free nids.
> If few nids left, three will introduce a lot of no hit
> read io.
I guess it is due to be lack of commit c1fe3e981440 ("Revert "f2fs:
reuse nids more aggressively""), before that commit, we will update
.next_scan_nid randomly instead of updating it ascendingly, then
during __build_free_nids we may readahead NAT pages starting from
random position.
Could try that commit to check IO again?
Thanks,
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2018-02-09 13:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 3:58 [PATCH] f2fs: remove unneed reada during build free nids Yunlei He
2018-02-09 13:36 ` Chao Yu [this message]
2018-02-11 1:55 ` heyunlei
2018-02-11 3:12 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb931c4a-7d7b-22f8-0ef8-ddd2fa880781@kernel.org \
--to=chao@kernel.org \
--cc=heyunlei@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).