linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Dongliang Mu <dzm91@hust.edu.cn>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com,
	Dongliang Mu <mudongliangabcd@gmail.com>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] fs: f2fs: remove WARN_ON in f2fs_is_valid_blkaddr
Date: Sat, 16 Apr 2022 10:29:39 +0800	[thread overview]
Message-ID: <ec26e65f-5e5d-3c99-d631-148717333cf5@kernel.org> (raw)
In-Reply-To: <20220415131902.55028-1-dzm91@hust.edu.cn>



On 2022/4/15 21:19, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@gmail.com>
> 
> Syzbot triggers two WARNs in f2fs_is_valid_blkaddr and
> __is_bitmap_valid. For example, in f2fs_is_valid_blkaddr,
> if type is DATA_GENERIC_ENHANCE or DATA_GENERIC_ENHANCE_READ,
> it invokes WARN_ON if blkaddr is not in the right range.
> The call trace is as follows:
> 
>   f2fs_get_node_info+0x45f/0x1070
>   read_node_page+0x577/0x1190
>   __get_node_page.part.0+0x9e/0x10e0
>   __get_node_page
>   f2fs_get_node_page+0x109/0x180
>   do_read_inode
>   f2fs_iget+0x2a5/0x58b0
>   f2fs_fill_super+0x3b39/0x7ca0
> 
> Fix these two WARNs by replacing WARN_ON with dump_stack.
> 
> Reported-by: syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

      reply	other threads:[~2022-04-16  2:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15 13:19 [f2fs-dev] [PATCH v2] fs: f2fs: remove WARN_ON in f2fs_is_valid_blkaddr Dongliang Mu
2022-04-16  2:29 ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec26e65f-5e5d-3c99-d631-148717333cf5@kernel.org \
    --to=chao@kernel.org \
    --cc=dzm91@hust.edu.cn \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mudongliangabcd@gmail.com \
    --cc=syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).