From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC
Date: Mon, 15 Aug 2022 11:38:00 +0800 [thread overview]
Message-ID: <f13d4881-820f-f6cd-4a70-c46ca3c5089f@kernel.org> (raw)
In-Reply-To: <20220811225454.2125297-1-jaegeuk@kernel.org>
On 2022/8/12 6:54, Jaegeuk Kim wrote:
> ATGC is using SSR which violates zoned device. >
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/super.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2451623c05a7..212ec2b4926b 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1298,6 +1298,10 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> F2FS_OPTION(sbi).discard_unit =
> DISCARD_UNIT_SECTION;
> }
> + if (test_opt(sbi, ATGC)) {
> + f2fs_err(sbi, "Zoned block device doesn't support ATGC.");
> + return -EINVAL;
> + }
ATGC is incompatible with LFS mode, we can check f2fs_lfs_mode() and ATGC
mountoption instead, as zoned device depends on LFS mode.
Thanks,
> }
>
> #ifdef CONFIG_F2FS_FS_COMPRESSION
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-08-15 3:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 22:54 [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC Jaegeuk Kim
2022-08-15 3:38 ` Chao Yu [this message]
2022-08-19 23:53 ` [f2fs-dev] [PATCH v2] f2fs: LFS mode " Jaegeuk Kim
2022-08-20 2:31 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13d4881-820f-f6cd-4a70-c46ca3c5089f@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).