* [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC
@ 2022-08-11 22:54 Jaegeuk Kim
2022-08-15 3:38 ` Chao Yu
2022-08-19 23:53 ` [f2fs-dev] [PATCH v2] f2fs: LFS mode " Jaegeuk Kim
0 siblings, 2 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2022-08-11 22:54 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel; +Cc: Jaegeuk Kim
ATGC is using SSR which violates zoned device.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/super.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2451623c05a7..212ec2b4926b 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1298,6 +1298,10 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
F2FS_OPTION(sbi).discard_unit =
DISCARD_UNIT_SECTION;
}
+ if (test_opt(sbi, ATGC)) {
+ f2fs_err(sbi, "Zoned block device doesn't support ATGC.");
+ return -EINVAL;
+ }
}
#ifdef CONFIG_F2FS_FS_COMPRESSION
--
2.37.1.559.g78731f0fdb-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC
2022-08-11 22:54 [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC Jaegeuk Kim
@ 2022-08-15 3:38 ` Chao Yu
2022-08-19 23:53 ` [f2fs-dev] [PATCH v2] f2fs: LFS mode " Jaegeuk Kim
1 sibling, 0 replies; 4+ messages in thread
From: Chao Yu @ 2022-08-15 3:38 UTC (permalink / raw)
To: Jaegeuk Kim, linux-kernel, linux-f2fs-devel
On 2022/8/12 6:54, Jaegeuk Kim wrote:
> ATGC is using SSR which violates zoned device. >
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/super.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2451623c05a7..212ec2b4926b 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1298,6 +1298,10 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
> F2FS_OPTION(sbi).discard_unit =
> DISCARD_UNIT_SECTION;
> }
> + if (test_opt(sbi, ATGC)) {
> + f2fs_err(sbi, "Zoned block device doesn't support ATGC.");
> + return -EINVAL;
> + }
ATGC is incompatible with LFS mode, we can check f2fs_lfs_mode() and ATGC
mountoption instead, as zoned device depends on LFS mode.
Thanks,
> }
>
> #ifdef CONFIG_F2FS_FS_COMPRESSION
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [f2fs-dev] [PATCH v2] f2fs: LFS mode does not support ATGC
2022-08-11 22:54 [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC Jaegeuk Kim
2022-08-15 3:38 ` Chao Yu
@ 2022-08-19 23:53 ` Jaegeuk Kim
2022-08-20 2:31 ` Chao Yu
1 sibling, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2022-08-19 23:53 UTC (permalink / raw)
To: linux-kernel, linux-f2fs-devel
ATGC is using SSR which violates LFS mode used by zoned device.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
Change log from v1:
- check LFS mode
fs/f2fs/super.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2451623c05a7..fe462484f5fa 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1342,6 +1342,11 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
return -EINVAL;
}
+ if (test_opt(sbi, ATGC) && f2fs_lfs_mode(sbi)) {
+ f2fs_err(sbi, "LFS not compatible with ATGC");
+ return -EINVAL;
+ }
+
if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
f2fs_err(sbi, "Allow to mount readonly mode only");
return -EROFS;
--
2.37.1.595.g718a3a8f04-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-20 2:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-11 22:54 [f2fs-dev] [PATCH] f2fs: zoned device does not support ATGC Jaegeuk Kim
2022-08-15 3:38 ` Chao Yu
2022-08-19 23:53 ` [f2fs-dev] [PATCH v2] f2fs: LFS mode " Jaegeuk Kim
2022-08-20 2:31 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).