From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1594C433EF for ; Sat, 7 May 2022 03:38:20 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nnBGv-0005NN-9p; Sat, 07 May 2022 03:38:19 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nnBGt-0005NC-Ez for linux-f2fs-devel@lists.sourceforge.net; Sat, 07 May 2022 03:38:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xyR5dKAKZznps+CYnNE5Kd34a0FQ2K1muKa08EoRUBE=; b=BYmM3zXWLzAWFxh5ahIUifL69w x7bpWIkMcksel6WdEwylx1uOBgb4ZIquPkKAkcuzjleCSnjRrOlPzQ5m4fe2w1Hnug87P6tCm0Ayh vqN7FneDpHTcm0xl4UHprA55fXSscjk3TNu/6tyWLXuthqW/KAZ4XDz6w6uuG+7iEtXE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xyR5dKAKZznps+CYnNE5Kd34a0FQ2K1muKa08EoRUBE=; b=WwBZjled1RPGzXKeRynQpI6bNW ftdeFW6/9gSaLjndZMsOdhgTa8svD64pEK85yxcyNR8EdqxLEM3N2SUmi8eb15M1qPXrQsFnv5fcW gne1h6yVAyZ0Kf1fyUcgbZLa2LE/w/n8nZvmynQn6RgQJAdpgPdgiy6rGVJAGwuov1ZM=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nnBGq-0000QW-Aq for linux-f2fs-devel@lists.sourceforge.net; Sat, 07 May 2022 03:38:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 10754B838E8; Sat, 7 May 2022 03:38:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 668AFC385A9; Sat, 7 May 2022 03:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651894688; bh=pNaBKUVWaTiM1LOs+4UULLBEnofJsYSuZRIS/1Zbj5M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mSdQqrG/mp5oSCOPSbVlFUS6nHMBug+yvJgZIh1LLNlnp/FIBAvCcBx9HCpfhOTlq Rxt82Dvoo9atZxiU9xiqFpsubC4hAfkWsE2GE7UMRo3FijGltlICkjJv2yJv9ptXfR CE8XRGIlguNFRtbt1WA1eIacec/RiTB6EqXPe0azWoSthoru8lK6OO59mpujGHFKxW jl/I2Gk3EQ4ME39+pXMuGc7KGArVAad9I2bAolZRAhp5Fh1JA8r/gANrbHDo+TvMvx p2fu9N3uBluwQdTVVMEyrDY5U7ninEI48uJxS7mDsHYjUS3KFUTbrjUg/q4b9N/IFc F/v9gRwEp0Y+A== Message-ID: Date: Sat, 7 May 2022 11:38:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: Jaegeuk Kim , Weichao Guo References: From: Chao Yu In-Reply-To: X-Headers-End: 1nnBGq-0000QW-Aq Subject: Re: [f2fs-dev] [PATCH] f2fs: skip GC if possible when checkpoint disabling X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangshiming@oppo.com, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/5/7 7:38, Jaegeuk Kim wrote: > On 05/07, Weichao Guo wrote: >> From: Weichao Guo >> >> If the number of unusable blocks is not larger than >> unusable capacity, we can skip GC when checkpoint >> disabling. > > I modified to fix restoring gc_mode back by the below. > > - unsigned int gc_mode; > + unsigned int gc_mode = sbi->gc_mode; > > >> >> Signed-off-by: Weichao Guo >> Signed-off-by: Chao Yu Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel