From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-nvme@lists.infradead.org,
Phillip Potter <phil@philpotter.co.uk>, Chris Mason <clm@fb.com>,
dm-devel@redhat.com, "Md. Haris Iqbal" <haris.iqbal@ionos.com>,
Pavel Machek <pavel@ucw.cz>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Jack Wang <jinpu.wang@ionos.com>,
linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
linux-pm@vger.kernel.org, linux-um@lists.infradead.org,
Josef Bacik <josef@toxicpanda.com>, Coly Li <colyli@suse.de>,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>,
Christian Brauner <brauner@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 05/30] cdrom: track if a cdrom_device_info was opened for data
Date: Fri, 9 Jun 2023 08:37:38 +0200 [thread overview]
Message-ID: <f398627e-f69f-de42-d55d-2d497d208ae5@suse.de> (raw)
In-Reply-To: <20230608110258.189493-6-hch@lst.de>
On 6/8/23 13:02, Christoph Hellwig wrote:
> Set a flag when a cdrom_device_info is opened for writing, instead of
> trying to figure out this at release time. This will allow to eventually
> remove the mode argument to the ->release block_device_operation as
> nothing but the CDROM drivers uses that argument.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
> Acked-by: Christian Brauner <brauner@kernel.org>
> ---
> drivers/cdrom/cdrom.c | 12 +++++-------
> include/linux/cdrom.h | 1 +
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-06-09 6:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 11:02 [f2fs-dev] decouple block open flags from fmode_t v2 Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 01/30] block: also call ->open for incremental partition opens Christoph Hellwig
2023-07-06 0:18 ` patchwork-bot+f2fs
2023-08-25 2:44 ` Al Viro
2023-08-28 12:09 ` Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 02/30] cdrom: remove the unused bdev argument to cdrom_open Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 03/30] cdrom: remove the unused mode argument to cdrom_ioctl Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 04/30] cdrom: remove the unused cdrom_close_write release code Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 05/30] cdrom: track if a cdrom_device_info was opened for data Christoph Hellwig
2023-06-09 6:37 ` Hannes Reinecke [this message]
2023-06-08 11:02 ` [f2fs-dev] [PATCH 06/30] cdrom: remove the unused mode argument to cdrom_release Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 07/30] block: pass a gendisk on bdev_check_media_change Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 08/30] block: pass a gendisk to ->open Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 09/30] block: remove the unused mode argument to ->release Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 10/30] block: rename blkdev_close to blkdev_release Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 11/30] swsusp: don't pass a stack address to blkdev_get_by_path Christoph Hellwig
2023-06-09 18:13 ` Rafael J. Wysocki
2023-06-08 11:02 ` [f2fs-dev] [PATCH 12/30] bcache: " Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 13/30] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 14/30] btrfs: " Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 15/30] block: use the holder as indication for exclusive opens Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 16/30] block: add a sb_open_mode helper Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 17/30] fs: remove sb->s_mode Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 18/30] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 19/30] scsi: replace the fmode_t argument to scsi_ioctl " Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 20/30] scsi: replace the fmode_t argument to ->sg_io_fn " Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 21/30] nvme: replace the fmode_t argument to the nvme ioctl handlers " Christoph Hellwig
2023-06-09 15:49 ` Keith Busch
2023-06-08 11:02 ` [f2fs-dev] [PATCH 22/30] mtd: block: use a simple bool to track open for write Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 23/30] rnbd-srv: replace sess->open_flags with a "bool readonly" Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 24/30] ubd: remove commented out code in ubd_open Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 25/30] block: move a few internal definitions out of blkdev.h Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 26/30] block: remove unused fmode_t arguments from ioctl handlers Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 27/30] block: replace fmode_t with a block-specific type for block open flags Christoph Hellwig
2023-06-08 11:45 ` Christian Brauner
2023-06-09 6:40 ` [f2fs-dev] [dm-devel] " Hannes Reinecke
2023-06-08 11:02 ` [f2fs-dev] [PATCH 28/30] block: always use I_BDEV on file->f_mapping->host to find the bdev Christoph Hellwig
2023-06-08 11:02 ` [f2fs-dev] [PATCH 29/30] block: store the holder in file->private_data Christoph Hellwig
2023-06-09 6:41 ` Hannes Reinecke
2023-06-08 11:02 ` [f2fs-dev] [PATCH 30/30] fs: remove the now unused FMODE_* flags Christoph Hellwig
2023-06-12 14:11 ` [f2fs-dev] decouple block open flags from fmode_t v2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f398627e-f69f-de42-d55d-2d497d208ae5@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=jinpu.wang@ionos.com \
--cc=josef@toxicpanda.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=miquel.raynal@bootlin.com \
--cc=pavel@ucw.cz \
--cc=phil@philpotter.co.uk \
--cc=rafael@kernel.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).