From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C655D2AB14 for ; Tue, 29 Oct 2024 10:11:56 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t5jCd-0005Vg-QD; Tue, 29 Oct 2024 10:11:55 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t5jCd-0005Va-Ek for linux-f2fs-devel@lists.sourceforge.net; Tue, 29 Oct 2024 10:11:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Ub0QjzAY+ioKamSPIgziT5r4UHeMULp3xKev9C0ktY=; b=j+J5IptTxeAPODGett0qqOVoZX FtDKFahlnbucfNZwY3+fI9KpEGt01ddfxm+4RGHP71qbUIS/EN5DqXi9r8XsjJ68DlhBZpz4OlH1Z lywz4CNVl+OGrCPoLJzGYULzWYm/4HlnGRv/UdOg14MuuyH0Bw/jVYDP4Vur3eD3LovE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6Ub0QjzAY+ioKamSPIgziT5r4UHeMULp3xKev9C0ktY=; b=C/ihY6tY5u4LihL0wJOc8kp+7t Z3JD5HdDfzAOD5bbtSWd6IhGofEM6AapEU/f24UFnEFWh6tRt5nMBTHYqRfVfe4TVASqoO4JReTtU rGKhTWyWcrRK83jirJxrsZvrXy6TrN6cillRQblGFdfloe7POLv8L05go8amTyctrzoc=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1t5jCc-0004Vr-2X for linux-f2fs-devel@lists.sourceforge.net; Tue, 29 Oct 2024 10:11:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9BF195C5C38; Tue, 29 Oct 2024 10:10:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20141C4CECD; Tue, 29 Oct 2024 10:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730196703; bh=BiaZqmDA5y1KrLYd+F5y0v/44itfzJjo5P3eIpyDVVA=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Gbm8e0bXg+uXXdYKpK608ovcsotSM/oPYjnDzLQTnc3YKuerIboL6rqmIGoSACSpP Q31oXbMzMQs23zh4tJtMQ46jsd2wSIrrqyedYZPM9gEwYe8co3pQ/xw/toyjkz/q4O EvfB89TMm1H6QJa1sYCPv3rysXyHblDvRy4h0eX42I4Hnzua2Thlpj9CUtwM1wdTpN cfj8vkiQ5jdPkdbD53+RqiCrUBURwYktHO+t/N8ClfNuJrX6gsEJlbzaPieTdYoVNb 8/S0EvI1ltDU9A38gG/DEUlvWhwaXWQQHgRlDRq6IDkEJtE5okanLqdHDXW9if/5ai BWbG3D8+GV4Nw== Message-ID: Date: Tue, 29 Oct 2024 18:11:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Zorro Lang References: <20241028141800.1788356-1-chao@kernel.org> <20241029060919.gxyywjp3gykaqnuc@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> <324c9b1a-ca86-43a4-8c3a-990199c714bc@kernel.org> <20241029085735.equs7ce55lcelgff@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> Content-Language: en-US In-Reply-To: <20241029085735.equs7ce55lcelgff@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com> X-Headers-End: 1t5jCc-0004Vr-2X Subject: Re: [f2fs-dev] [PATCH v3 1/2] f2fs/006: add testcase to check out-of-space case X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: Jaegeuk Kim , fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2024/10/29 16:57, Zorro Lang wrote: > On Tue, Oct 29, 2024 at 03:46:21PM +0800, Chao Yu wrote: >> On 2024/10/29 14:09, Zorro Lang wrote: >>> On Mon, Oct 28, 2024 at 10:17:59PM +0800, Chao Yu wrote: >>>> This is a regression test to check whether f2fs handles dirty >>>> data correctly when checkpoint is disabled, if lfs mode is on, >>>> it will trigger OPU for all overwritten data, this will cost >>>> free segments, so f2fs must account overwritten data as OPU >>>> data when calculating free space, otherwise, it may run out >>>> of free segments in f2fs' allocation function. If kernel config >>>> CONFIG_F2FS_CHECK_FS is on, it will cause system panic, otherwise, >>>> dd may encounter I/O error. >>>> >>>> Cc: Jaegeuk Kim >>>> Signed-off-by: Chao Yu >>>> --- >>>> v3: >>>> - explain more about behavior on kernel w/ different config >>>> - use _filter_scratch to filter $SCRATCH_MNT >>>> tests/f2fs/006 | 42 ++++++++++++++++++++++++++++++++++++++++++ >>>> tests/f2fs/006.out | 6 ++++++ >>>> 2 files changed, 48 insertions(+) >>>> create mode 100755 tests/f2fs/006 >>>> create mode 100644 tests/f2fs/006.out >>>> >>>> diff --git a/tests/f2fs/006 b/tests/f2fs/006 >>>> new file mode 100755 >>>> index 00000000..f9560b2b >>>> --- /dev/null >>>> +++ b/tests/f2fs/006 >>>> @@ -0,0 +1,42 @@ >>>> +#! /bin/bash >>>> +# SPDX-License-Identifier: GPL-2.0 >>>> +# Copyright (c) 2024 Oppo. All Rights Reserved. >>>> +# >>>> +# FS QA Test No. f2fs/006 >>>> +# >>>> +# This is a regression test to check whether f2fs handles dirty >>>> +# data correctly when checkpoint is disabled, if lfs mode is on, >>>> +# it will trigger OPU for all overwritten data, this will cost >>>> +# free segments, so f2fs must account overwritten data as OPU >>>> +# data when calculating free space, otherwise, it may run out >>>> +# of free segments in f2fs' allocation function. If kernel config >>>> +# CONFIG_F2FS_CHECK_FS is on, it will cause system panic, otherwise, >>>> +# dd may encounter I/O error. >>>> +# >>>> +. ./common/preamble >>>> +_begin_fstest auto quick >>>> + >>>> +_fixed_by_kernel_commit xxxxxxxxxxxx \ >>>> + "f2fs: fix to account dirty data in __get_secs_required()" >>>> + >>>> +# Import common functions. >>>> +. ./common/filter >>>> + >>>> +_require_scratch >>>> +_scratch_mkfs_sized $((1024*1024*100)) >> $seqres.full >>>> + >>>> +# use mode=lfs to let f2fs always triggers OPU >>>> +_scratch_mount -o mode=lfs,checkpoint=disable:10%,noinline_dentry >> $seqres.full >>>> + >>>> +testfile=$SCRATCH_MNT/testfile >>>> + >>>> +dd if=/dev/zero of=$testfile bs=1M count=50 2>/dev/null >>>> + >>>> +# it may run out of free space of f2fs and hang kernel >>>> +dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync >>>> +dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync 2>&1 | _filter_scratch >>>> + >>>> +_scratch_remount checkpoint=enable >>>> + >>>> +status=0 >>>> +exit >>>> diff --git a/tests/f2fs/006.out b/tests/f2fs/006.out >>>> new file mode 100644 >>>> index 00000000..2dc9efda >>>> --- /dev/null >>>> +++ b/tests/f2fs/006.out >>>> @@ -0,0 +1,6 @@ >>>> +QA output created by 006 >>>> +50+0 records in >>>> +50+0 records out >>>> +dd: error writing 'SCRATCH_MNT/testfile': No space left on device >>>> +3+0 records in >>>> +2+0 records out >>> >>> Hi Chao, >>> >>> One more question about this patch. >>> >>> I'm wondering can this output always be matched? If the test doesn't care the dd output, >>> you can filter out them, to avoid it break golden image. Especially the second one, can >>> you be sure it always "3 in and 2 out" before returning ENOSPC? >> >> Zorro, >> >> I got your concern, how about using _check_dmesg to catch the kernel >> bug instead? since once the bug was triggered, f2fs will call BUG_ON >> or WARN_ON optionally anyway. > > Hi Chao, > > The _check_dmesg is always called at the end of each test. Except you > need a dmesg filter, or you don't need to call it manually. Zorro, Oh, alright. > > My concern is "unstable output cause unexpected failure on fixed kernel". > If you think the last "dd" output is unstable and useless on fixed kernel, > you can filter it out, just let the dmesg/hang break the test. I just confirmed that the output may change according to mkfs.f2fs option, so I guess we'd better ignore output of dd, and check dmesg instead. > > e.g. > > # The 2nd dd might run out of space, and trigger a kernel warning or hang on > # unfixed kernel > dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync >/dev/null > dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync 2>&1 >/dev/null | _filter_scratch > > or if you feel the error output isn't stable either, you can: > > # The 2nd dd might run out of space, and trigger a kernel warning or hang on > # unfixed kernel > dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync >>$seqres.full > dd if=/dev/zero of=$testfile bs=1M count=50 conv=notrunc conv=fsync >>$seqres.full 2>&1 > ... > echo "Silence is golden" I think we can use above code to make output stable, thanks for your suggestion. :) Thanks, > > Or if you need those output, please make sure it's a stable output on any fixed > system :) > > Thanks, > Zorro > >> >> Thanks, >> >>> >>> Thanks, >>> Zorro >>> >>>> -- >>>> 2.40.1 >>>> >>> >> > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel