From: Chao Yu <chao@kernel.org>
To: Wu Bo <wubo.oduw@gmail.com>, Wu Bo <bo.wu@vivo.com>,
Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN happens"
Date: Tue, 20 Feb 2024 14:50:11 +0800 [thread overview]
Message-ID: <f51946e2-68f4-4368-9a77-050382dfa3ff@kernel.org> (raw)
In-Reply-To: <bab0d763-2907-4412-8075-a7ebb25081c0@gmail.com>
On 2024/2/8 16:11, Wu Bo wrote:
> On 2024/2/5 11:54, Chao Yu wrote:
>> How about calling f2fs_balance_fs() to double check and make sure there is
>> enough free space for following allocation.
>>
>> if (has_not_enough_free_secs(sbi, 0,
>> GET_SEC_FROM_SEG(sbi, overprovision_segments(sbi)))) {
>> f2fs_down_write(&sbi->gc_lock);
>> stat_inc_gc_call_count(sbi, FOREGROUND);
>> err = f2fs_gc(sbi, &gc_control);
>> if (err == -EAGAIN)
>> f2fs_balance_fs(sbi, true);
>> if (err && err != -ENODATA)
>> goto out_err;
>> }
>>
>> Thanks,
>
> f2fs_balance_fs() here will not change procedure branch and may just trigger another GC.
>
> I'm afraid this is a bit redundant.
Okay.
I guess maybe Jaegeuk has concern which is the reason to commit
2e42b7f817ac ("f2fs: stop allocating pinned sections if EAGAIN happens").
Thanks,
>
>>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-02-20 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 3:14 [f2fs-dev] [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN happens" Wu Bo via Linux-f2fs-devel
2024-02-05 3:54 ` Chao Yu
2024-02-08 8:11 ` Wu Bo
2024-02-20 6:50 ` Chao Yu [this message]
2024-09-06 8:31 ` Wu Bo via Linux-f2fs-devel
2024-09-06 10:07 ` Chao Yu via Linux-f2fs-devel
2024-09-06 22:52 ` Jaegeuk Kim via Linux-f2fs-devel
2024-09-10 8:33 ` Wu Bo via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f51946e2-68f4-4368-9a77-050382dfa3ff@kernel.org \
--to=chao@kernel.org \
--cc=bo.wu@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wubo.oduw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).