From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: jaegeuk@kernel.org, yuchao0@huawei.com
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [BUG] fs: f2fs: Possible null-pointer dereferences in update_general_status()
Date: Thu, 25 Jul 2019 17:49:44 +0800 [thread overview]
Message-ID: <f577be2f-fc2f-9ef8-2c6c-9c247123b1ad@gmail.com> (raw)
In update_general_status(), there are two if statements to
check whether SM_I(sbi) is NULL:
LINE 70: if (SM_I(sbi) && SM_I(sbi)->fcc_info)
LINE 78: if (SM_I(sbi) && SM_I(sbi)->dcc_info)
When SM_I(sbi) is NULL, it is used at some places, such as:
LINE 88: reserved_segments(sbi)
return SM_I(sbi)->reserved_segments;
LINE 89: overprovision_segments(sbi)
return SM_I(sbi)->ovp_segments;
LINE 112: MAIN_SEGS(sbi)
(SM_I(sbi)->main_segments)
Thus, possible null-pointer dereferences may occur.
These bugs are found by a static analysis tool STCheck written by us.
I do not know how to correctly fix these bugs, so I only report them.
Best wishes,
Jia-Ju Bai
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2019-07-25 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 9:49 Jia-Ju Bai [this message]
2019-07-26 3:19 ` [f2fs-dev] [BUG] fs: f2fs: Possible null-pointer dereferences in update_general_status() Chao Yu
2019-07-26 3:39 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f577be2f-fc2f-9ef8-2c6c-9c247123b1ad@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).