From: Chao Yu <chao@kernel.org>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: Prevent swap file in LFS mode
Date: Mon, 10 May 2021 19:50:46 +0800 [thread overview]
Message-ID: <f7d561a9-3404-7ce2-21ef-3de583f22db4@kernel.org> (raw)
In-Reply-To: <20210510112444.902964-1-shinichiro.kawasaki@wdc.com>
On 2021/5/10 19:24, Shin'ichiro Kawasaki wrote:
> The kernel writes to swap files on f2fs directly without the assistance
> of the filesystem. This direct write by kernel can be non-sequential
> even when the f2fs is in LFS mode. Such non-sequential write conflicts
> with the LFS semantics. Especially when f2fs is set up on zoned block
> devices, the non-sequential write causes unaligned write command errors.
>
> To avoid the non-sequential writes to swap files, prevent swap file
> activation when the filesystem is in LFS mode.
>
> Fixes: 4969c06a0d83 ("f2fs: support swap file w/ DIO")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> Cc: stable@vger.kernel.org # v5.10
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2021-05-10 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 11:24 [f2fs-dev] [PATCH v2] f2fs: Prevent swap file in LFS mode Shin'ichiro Kawasaki
2021-05-10 11:50 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d561a9-3404-7ce2-21ef-3de583f22db4@kernel.org \
--to=chao@kernel.org \
--cc=Damien.LeMoal@wdc.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).