From: Chao Yu <chao@kernel.org>
To: cgxu519 <cgxu519@gmx.com>, linux-f2fs-devel@lists.sourceforge.net
Cc: jaegeuk@kernel.org
Subject: Re: mount fail with option fault_injection < 20000 && >0
Date: Tue, 18 Sep 2018 20:21:28 +0800 [thread overview]
Message-ID: <fa4fccef-e9d5-50be-dd29-d1f531f2ddf4@kernel.org> (raw)
In-Reply-To: <61afbde5-f05e-9bd5-8dc2-31932c13cd51@gmx.com>
Hi Chengguang,
On 2018/9/18 19:02, cgxu519 wrote:
> HI guys,
>
> I found mount with option fault_injection < 20000 && >0 will fail with error
> -ENOMEM.
> I understand fault_injection function is explicitly mocking some errors, but
If we skip injecting error into memory allocation functions during mount, we may
miss checking most error paths in fill_super(). So I think we really need this
during mount.
But if you want to inject error after mount, you can reenable error injection by
configuring fault_injection/fault_rate sysfs entry.
Thanks,
> isn't it better
> mocking errors after successful mount? Is it really allocating memory so many times
> during mount process?
>
> Thanks,
> Chengguang
>
>
>
>
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2018-09-18 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 11:02 mount fail with option fault_injection < 20000 && >0 cgxu519
2018-09-18 12:21 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa4fccef-e9d5-50be-dd29-d1f531f2ddf4@kernel.org \
--to=chao@kernel.org \
--cc=cgxu519@gmx.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).