* mount fail with option fault_injection < 20000 && >0
@ 2018-09-18 11:02 cgxu519
2018-09-18 12:21 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: cgxu519 @ 2018-09-18 11:02 UTC (permalink / raw)
To: linux-f2fs-devel; +Cc: jaegeuk
HI guys,
I found mount with option fault_injection < 20000 && >0 will fail with
error -ENOMEM.
I understand fault_injection function is explicitly mocking some errors,
but isn't it better
mocking errors after successful mount? Is it really allocating memory so
many times
during mount process?
Thanks,
Chengguang
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mount fail with option fault_injection < 20000 && >0
2018-09-18 11:02 mount fail with option fault_injection < 20000 && >0 cgxu519
@ 2018-09-18 12:21 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2018-09-18 12:21 UTC (permalink / raw)
To: cgxu519, linux-f2fs-devel; +Cc: jaegeuk
Hi Chengguang,
On 2018/9/18 19:02, cgxu519 wrote:
> HI guys,
>
> I found mount with option fault_injection < 20000 && >0 will fail with error
> -ENOMEM.
> I understand fault_injection function is explicitly mocking some errors, but
If we skip injecting error into memory allocation functions during mount, we may
miss checking most error paths in fill_super(). So I think we really need this
during mount.
But if you want to inject error after mount, you can reenable error injection by
configuring fault_injection/fault_rate sysfs entry.
Thanks,
> isn't it better
> mocking errors after successful mount? Is it really allocating memory so many times
> during mount process?
>
> Thanks,
> Chengguang
>
>
>
>
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-18 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-18 11:02 mount fail with option fault_injection < 20000 && >0 cgxu519
2018-09-18 12:21 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).