From: Chao Yu <yuchao0@huawei.com>
To: Yunlong Song <yunlong.song@huawei.com>,
jaegeuk@kernel.org, chao@kernel.org, yunlong.song@icloud.com
Cc: miaoxie@huawei.com, bintian.wang@huawei.com,
linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs-tools: support CP_CRC_RECOVERY_FLAG check
Date: Mon, 11 Sep 2017 18:32:13 +0800 [thread overview]
Message-ID: <ff7842f7-6781-01e7-258b-d1b6dc844774@huawei.com> (raw)
In-Reply-To: <1504794297-150702-1-git-send-email-yunlong.song@huawei.com>
Hi Yunlong,
Do we need to recover other flags?
Thanks,
On 2017/9/7 22:24, Yunlong Song wrote:
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> fsck/fsck.c | 3 +++
> fsck/mount.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/fsck/fsck.c b/fsck/fsck.c
> index cb341ba..f63a609 100644
> --- a/fsck/fsck.c
> +++ b/fsck/fsck.c
> @@ -1786,6 +1786,9 @@ static void fix_checkpoint(struct f2fs_sb_info *sbi)
> set_cp(cp_pack_total_block_count, 8 + orphan_blks + get_sb(cp_payload));
>
> flags = update_nat_bits_flags(sb, cp, flags);
> +
> + if (is_set_ckpt_flags(cp, CP_CRC_RECOVERY_FLAG))
> + flags |= CP_CRC_RECOVERY_FLAG;
> set_cp(ckpt_flags, flags);
>
> set_cp(free_segment_count, get_free_segments(sbi));
> diff --git a/fsck/mount.c b/fsck/mount.c
> index 7a8aeae..0d77cce 100644
> --- a/fsck/mount.c
> +++ b/fsck/mount.c
> @@ -1902,6 +1902,9 @@ void write_checkpoint(struct f2fs_sb_info *sbi)
> set_cp(cp_pack_total_block_count, 8 + orphan_blks + get_sb(cp_payload));
>
> flags = update_nat_bits_flags(sb, cp, flags);
> +
> + if (is_set_ckpt_flags(cp, CP_CRC_RECOVERY_FLAG))
> + flags |= CP_CRC_RECOVERY_FLAG;
> set_cp(ckpt_flags, flags);
>
> crc = f2fs_cal_crc32(F2FS_SUPER_MAGIC, cp, CHECKSUM_OFFSET);
>
prev parent reply other threads:[~2017-09-11 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 14:24 [PATCH] f2fs-tools: support CP_CRC_RECOVERY_FLAG check Yunlong Song
2017-09-11 10:32 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7842f7-6781-01e7-258b-d1b6dc844774@huawei.com \
--to=yuchao0@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=yunlong.song@huawei.com \
--cc=yunlong.song@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).