From: Edward Adam Davis via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: syzbot+78ff2855f26377625419@syzkaller.appspotmail.com
Cc: jaegeuk@kernel.org, syzkaller-bugs@googlegroups.com,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [syzbot] [f2fs?] WARNING: lock held when returning to user space in f2fs_commit_atomic_write
Date: Wed, 14 Aug 2024 08:48:40 +0800 [thread overview]
Message-ID: <tencent_E51B7925E5BAF4BBCF33739E5E1BFA4B9F08@qq.com> (raw)
In-Reply-To: <000000000000ebae95061f96be85@google.com>
unlock i_gc_rwsem[WRITE] before quiting f2fs_commit_atomic_write
Fixes: 7566a155c666 ("f2fs: atomic: fix to not allow GC to pollute atomic_file")
Reported-by: syzbot+78ff2855f26377625419@syzkaller.appspotmail.com
#syz test: net-next 9e6869691724
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 741e46f9d0fd..a43054ab0cf1 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -389,13 +389,13 @@ int f2fs_commit_atomic_write(struct inode *inode)
err = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
if (err)
- return err;
+ goto out;
/* writeback GCing page of cow_inode */
err = filemap_write_and_wait_range(fi->cow_inode->i_mapping,
0, LLONG_MAX);
if (err)
- return err;
+ goto out;
filemap_invalidate_lock(inode->i_mapping);
@@ -407,6 +407,7 @@ int f2fs_commit_atomic_write(struct inode *inode)
f2fs_unlock_op(sbi);
filemap_invalidate_unlock(inode->i_mapping);
+out:
f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
return err;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-08-14 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 20:49 [f2fs-dev] [syzbot] [f2fs?] WARNING: lock held when returning to user space in f2fs_commit_atomic_write syzbot
2024-08-14 0:48 ` Edward Adam Davis via Linux-f2fs-devel [this message]
2024-08-14 3:21 ` syzbot
2024-08-14 3:33 ` Chao Yu
2024-08-14 6:01 ` Edward Adam Davis via Linux-f2fs-devel
2024-09-05 1:31 ` Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_E51B7925E5BAF4BBCF33739E5E1BFA4B9F08@qq.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=eadavis@qq.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+78ff2855f26377625419@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).