From: Jingoo Han <jg1.han@samsung.com>
To: 'Florian Tobias Schandinat' <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
'Olof Johansson' <olof@lixom.net>,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] video: exynos_dp: fix build warning due to uninitialized value
Date: Wed, 20 Jun 2012 00:54:49 +0000 [thread overview]
Message-ID: <000001cd4e7f$4b9a29e0$e2ce7da0$%han@samsung.com> (raw)
In-Reply-To: <4FE11D60.9040109@gmx.de>
On Wed, June 20, 2012 at 9:46 AM, Florian Tobias Schandinat wrote:
> Hi Jingoo,
>
> On 06/19/2012 06:36 AM, Jingoo Han wrote:
> > This patch fixes build warning due to uninitialized value dereference.
> > @@ -407,6 +407,8 @@ static unsigned int exynos_dp_get_lane_link_training(
> > case 3:
> > reg = exynos_dp_get_lane3_link_training(dp);
> > break;
> > + default:
> > + return -EINVAL;
>
> Why do you consider returning -EINVAL here a good idea? As far as I can
> see the caller does not check the return value for an error condition
> and I doubt that the hardware understands what -EINVAL means. If you
> want to fix the warning, make sure that you don't hide actual errors,
> add an WARN or BUG or make sure the error code makes it to userspace.
>
OK, I will fix it and send the v2 patch.
Thank you.
Best regards,
Jingoo Han
prev parent reply other threads:[~2012-06-20 0:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 6:36 [PATCH] video: exynos_dp: fix build warning due to uninitialized value Jingoo Han
2012-06-20 0:46 ` Florian Tobias Schandinat
2012-06-20 0:54 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001cd4e7f$4b9a29e0$e2ce7da0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).