linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video: exynos_dp: replace link_status with link_align to check channel equalization
@ 2012-09-03  8:50 Jingoo Han
  2012-09-23 19:37 ` Florian Tobias Schandinat
  0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2012-09-03  8:50 UTC (permalink / raw)
  To: linux-fbdev

To check channel equalization, the value of LANE_ALIGN_STATUS_UPDATED is
necessary in exynos_dp_channel_eq_ok(). Also, link_align includes this value.
However, link_status does not include this value, so it makes the problem
that channel equalization is failed during link training.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/video/exynos/exynos_dp_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c
index f57c915..cdc1398 100644
--- a/drivers/video/exynos/exynos_dp_core.c
+++ b/drivers/video/exynos/exynos_dp_core.c
@@ -587,7 +587,7 @@ static int exynos_dp_process_equalizer_training(struct exynos_dp_device *dp)
 			dp->link_train.training_lane[lane] = training_lane;
 		}
 
-		if (exynos_dp_channel_eq_ok(link_status, lane_count) = 0) {
+		if (exynos_dp_channel_eq_ok(link_align, lane_count) = 0) {
 			/* traing pattern Set to Normal */
 			exynos_dp_training_pattern_dis(dp);
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] video: exynos_dp: replace link_status with link_align to check channel equalization
  2012-09-03  8:50 [PATCH] video: exynos_dp: replace link_status with link_align to check channel equalization Jingoo Han
@ 2012-09-23 19:37 ` Florian Tobias Schandinat
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-09-23 19:37 UTC (permalink / raw)
  To: linux-fbdev

On 09/03/2012 08:50 AM, Jingoo Han wrote:
> To check channel equalization, the value of LANE_ALIGN_STATUS_UPDATED is
> necessary in exynos_dp_channel_eq_ok(). Also, link_align includes this value.
> However, link_status does not include this value, so it makes the problem
> that channel equalization is failed during link training.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/exynos/exynos_dp_core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c
> index f57c915..cdc1398 100644
> --- a/drivers/video/exynos/exynos_dp_core.c
> +++ b/drivers/video/exynos/exynos_dp_core.c
> @@ -587,7 +587,7 @@ static int exynos_dp_process_equalizer_training(struct exynos_dp_device *dp)
>  			dp->link_train.training_lane[lane] = training_lane;
>  		}
>  
> -		if (exynos_dp_channel_eq_ok(link_status, lane_count) = 0) {
> +		if (exynos_dp_channel_eq_ok(link_align, lane_count) = 0) {
>  			/* traing pattern Set to Normal */
>  			exynos_dp_training_pattern_dis(dp);
>  


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-23 19:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-03  8:50 [PATCH] video: exynos_dp: replace link_status with link_align to check channel equalization Jingoo Han
2012-09-23 19:37 ` Florian Tobias Schandinat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).