From: "Jingoo Han" <jingoohan1@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight: pwm: make use of 3rd argument to devm_gpiod_get_optional
Date: Mon, 18 May 2015 23:15:25 +0000 [thread overview]
Message-ID: <000001d091c0$88f832a0$9ae897e0$@com> (raw)
In-Reply-To: <1431983162-21494-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Tuesday, May 19, 2015 6:06 AM, Uwe Kleine-König wrote:
>
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which
> appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter
> that allows to specify direction and initial value for output.
>
> This allows to drop the explicit setting of direction.
>
> Furthermore this is one caller less that stops us making the 3rd
> argument mandatory.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
+cc Axel Lin
Hi Uwe Kleine-König,
The same patch was already sent by Axel Lin 3 days ago.
Anyway, thank you for sending the patch.
Best regards,
Jingoo Han
> ---
> drivers/video/backlight/pwm_bl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 3a145a643e0d..57cb9ec8be43 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -241,7 +241,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> pb->dev = &pdev->dev;
> pb->enabled = false;
>
> - pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
> + pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
> + GPIOD_OUT_HIGH);
> if (IS_ERR(pb->enable_gpio)) {
> ret = PTR_ERR(pb->enable_gpio);
> goto err_alloc;
> @@ -263,9 +264,6 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> pb->enable_gpio = gpio_to_desc(data->enable_gpio);
> }
>
> - if (pb->enable_gpio)
> - gpiod_direction_output(pb->enable_gpio, 1);
> -
> pb->power_supply = devm_regulator_get(&pdev->dev, "power");
> if (IS_ERR(pb->power_supply)) {
> ret = PTR_ERR(pb->power_supply);
> --
> 2.1.4
prev parent reply other threads:[~2015-05-18 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 21:06 [PATCH] backlight: pwm: make use of 3rd argument to devm_gpiod_get_optional Uwe Kleine-König
2015-05-18 23:15 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d091c0$88f832a0$9ae897e0$@com' \
--to=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).