From: "Jingoo Han" <jingoohan1@gmail.com>
To: 'Daniel Thompson' <daniel.thompson@linaro.org>,
'Arvind Yadav' <arvind.yadav.cs@gmail.com>,
thierry.reding@gmail.com, lee.jones@linaro.org,
b.zolnierkie@samsung.com
Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: pwm_bl: make of_device_ids const
Date: Tue, 20 Jun 2017 13:59:06 +0000 [thread overview]
Message-ID: <000001d2e9cd$624285e0$26c791a0$@gmail.com> (raw)
In-Reply-To: <2574238d-640f-79b3-4650-c51766b4a478@linaro.org>
On Tuesday, June 20, 2017 6:53 AM, Daniel Thompson wrote:
>
> On 20/06/17 08:52, Arvind Yadav wrote:
> > of_device_ids are not supposed to change at runtime. All functions
> > working with of_device_ids provided by <linux/of.h> work with const
> > of_device_ids. So mark the non-const structs as const.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
>
>
> > ---
> > drivers/video/backlight/pwm_bl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c
> b/drivers/video/backlight/pwm_bl.c
> > index 002f1ce..9bd1768 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
> > return 0;
> > }
> >
> > -static struct of_device_id pwm_backlight_of_match[] = {
> > +static const struct of_device_id pwm_backlight_of_match[] = {
> > { .compatible = "pwm-backlight" },
> > { }
> > };
> >
next prev parent reply other threads:[~2017-06-20 13:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 7:52 [PATCH] backlight: pwm_bl: make of_device_ids const Arvind Yadav
2017-06-20 10:52 ` Daniel Thompson
2017-06-20 13:59 ` Jingoo Han [this message]
2017-07-06 6:42 ` Thierry Reding
2017-07-17 12:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d2e9cd$624285e0$26c791a0$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).