From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jingoo Han" Date: Tue, 20 Jun 2017 13:59:06 +0000 Subject: Re: [PATCH] backlight: pwm_bl: make of_device_ids const Message-Id: <000001d2e9cd$624285e0$26c791a0$@gmail.com> List-Id: References: <2574238d-640f-79b3-4650-c51766b4a478@linaro.org> In-Reply-To: <2574238d-640f-79b3-4650-c51766b4a478@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Daniel Thompson' , 'Arvind Yadav' , thierry.reding@gmail.com, lee.jones@linaro.org, b.zolnierkie@samsung.com Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Tuesday, June 20, 2017 6:53 AM, Daniel Thompson wrote: > > On 20/06/17 08:52, Arvind Yadav wrote: > > of_device_ids are not supposed to change at runtime. All functions > > working with of_device_ids provided by work with const > > of_device_ids. So mark the non-const structs as const. > > > > Signed-off-by: Arvind Yadav > > Acked-by: Daniel Thompson Acked-by: Jingoo Han Best regards, Jingoo Han > > > > --- > > drivers/video/backlight/pwm_bl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/backlight/pwm_bl.c > b/drivers/video/backlight/pwm_bl.c > > index 002f1ce..9bd1768 100644 > > --- a/drivers/video/backlight/pwm_bl.c > > +++ b/drivers/video/backlight/pwm_bl.c > > @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev, > > return 0; > > } > > > > -static struct of_device_id pwm_backlight_of_match[] = { > > +static const struct of_device_id pwm_backlight_of_match[] = { > > { .compatible = "pwm-backlight" }, > > { } > > }; > >