From: Jingoo Han <jg1.han@samsung.com>
To: 'Yijing Wang' <wangyijing@huawei.com>,
'Jean-Christophe Plagniol-Villard' <plagnioj@jcrosoft.com>,
'Tomi Valkeinen' <tomi.valkeinen@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
'Hanjun Guo' <guohanjun@huawei.com>,
jiang.liu@huawei.com, Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] video: remove unused variable "dev" in vga16fb_destroy()
Date: Mon, 15 Jul 2013 07:13:56 +0000 [thread overview]
Message-ID: <000101ce812a$dec735d0$9c55a170$@samsung.com> (raw)
In-Reply-To: <1373869765-52572-1-git-send-email-wangyijing@huawei.com>
On Monday, July 15, 2013 3:29 PM, Yijing Wang wrote:
>
> Delete unused variable "dev" to fix build warning in
> drivers/video/vga16fb.c
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
It looks good.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/video/vga16fb.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>
> static void vga16fb_destroy(struct fb_info *info)
> {
> - struct platform_device *dev = container_of(info->device, struct platform_device, dev);
> iounmap(info->screen_base);
> fb_dealloc_cmap(&info->cmap);
> /* XXX unshare VGA regions */
> --
> 1.7.1
prev parent reply other threads:[~2013-07-15 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 6:29 [PATCH] video: remove unused variable "dev" in vga16fb_destroy() Yijing Wang
2013-07-15 7:13 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101ce812a$dec735d0$9c55a170$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=guohanjun@huawei.com \
--cc=jiang.liu@huawei.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).